[GitHub] ocafebabe commented on a change in pull request #491: Allow to postprocess downloaded binaries

[GitBox <gi...@apache.org>]

ocafebabe commented on a change in pull request #491: Allow to postprocess downloaded binaries
URL: https://github.com/apache/incubator-netbeans/pull/491#discussion_r185975927
 
 

 ##########
 File path: nbbuild/templates/projectized.xml
 ##########
 @@ -230,14 +230,19 @@ If you are sure you want to build with JDK 9+ anyway, use: -Dpermit.jdk9.builds=
     <target name="-define-downloadbinaries-task" unless="have-downloadbinaries-task">
         <taskdef name="downloadbinaries" classname="org.netbeans.nbbuild.extlibs.DownloadBinaries" classpath="${nbantext.jar}"/>
     </target>
-
-    <!-- See: http://wiki.netbeans.org/wiki/view/DevFaqExternalLibrariesUpdated -->
-    <target name="-release.files" depends="projectized-common.-release.files,-define-downloadbinaries-task">
+    
+    <target name="-process.release.files"/>
+    
+    <target name="-download.release.files" depends="-define-downloadbinaries-task">
         <downloadbinaries cache="${binaries.cache}" server="${binaries.server}">
             <manifest dir=".">
                 <include name="external/binaries-list"/>
             </manifest>
         </downloadbinaries>
+    </target>
+
+    <!-- See: http://wiki.netbeans.org/wiki/view/DevFaqExternalLibrariesUpdated -->
+    <target name="-release.files" depends="projectized-common.-release.files,-download.release.files,-process.release.files">
 
 Review comment:
   The wiki page referenced in the comment doesn't seem to work anymore!
   
   ![screenshot from 2018-05-03 21-26-02](https://user-images.githubusercontent.com/3409735/39609662-9de28af8-4f18-11e8-8541-d5ba419c66e8.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists