You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/19 02:17:50 UTC

[GitHub] graceguo-supercat commented on a change in pull request #5418: Retire dashboard v1 (js and python)

graceguo-supercat commented on a change in pull request #5418: Retire dashboard v1 (js and python)
URL: https://github.com/apache/incubator-superset/pull/5418#discussion_r203584807
 
 

 ##########
 File path: superset/assets/src/dashboard/components/Dashboard.jsx
 ##########
 @@ -86,9 +86,7 @@ class Dashboard extends React.PureComponent {
 
   componentWillReceiveProps(nextProps) {
     if (!nextProps.dashboardState.editMode) {
-      const version = nextProps.dashboardState.isV2Preview
-        ? 'v2-preview'
-        : 'v2';
+      const version = 'v2';
 
 Review comment:
   fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org