Re: [PR] HTTPCLIENT-1165: Add optional request collapsing for async cache misses [httpcomponents-client]

["arturobernalg (via GitHub)" <gi...@apache.org>]

arturobernalg commented on PR #781:
URL: https://github.com/apache/httpcomponents-client/pull/781#issuecomment-4528042034

   > @arturobernalg There is a lot of complexity in this change-set for what I personally see is little practical gain.
   > 
   > Question. How well is this tested? How sure you are this is going to work reliably?
   
   @ok2c 
   I added additional coverage for the unsafe paths: leader failure, leader cancellation, non-cacheable responses, Vary, request entities and only-if-cached. I also kept request collapsing disabled by default and scoped to each caching executor.
   The local smoke example produces 20 origin requests without collapsing and 1 with collapsing enabled for concurrent cold misses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org