You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Marc Spaggiari (JIRA)" <ji...@apache.org> on 2013/09/26 06:32:05 UTC
[jira] [Commented] (HBASE-9661) Consistent log severity level
guards and statements
[ https://issues.apache.org/jira/browse/HBASE-9661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778466#comment-13778466 ]
Jean-Marc Spaggiari commented on HBASE-9661:
--------------------------------------------
Make sense to me. +1
> Consistent log severity level guards and statements
> ----------------------------------------------------
>
> Key: HBASE-9661
> URL: https://issues.apache.org/jira/browse/HBASE-9661
> Project: HBase
> Issue Type: Improvement
> Reporter: Jackie Chang
> Priority: Minor
> Attachments: HBASE-9661.patch
>
>
> A log statement should be guarded by its matching severity level. A log statement like
> if (LOG.isTraceEnabled()) {
> LOG.debug(identifier + " opening connection to ZooKeeper ensemble=" + ensemble);
> doesn't make much sense because the log message is only printed out when TRACE-level is enabled. This inconsistency was possibly introduced when developers demoted the original log statement from DEBUG but forgot to change its corresponding log severity level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira