You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Lily Chen <li...@mesosphere.io> on 2015/08/28 01:00:13 UTC

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35330/
-----------------------------------------------------------

(Updated Aug. 27, 2015, 11 p.m.)


Review request for mesos and Timothy Chen.


Changes
-------

Added a TODO to address generalizing functionality, addressed comments and rebased on master.


Bugs: MESOS-2797
    https://issues.apache.org/jira/browse/MESOS-2797


Repository: mesos


Description
-------

Capped number of parallel inspect instances on a docker ps call.


Diffs (updated)
-----

  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/slave/constants.hpp ccfe89c44556de619139551eb988cceebc88bdb5 

Diff: https://reviews.apache.org/r/35330/diff/


Testing
-------

sudo ./mesos-tests.sh --gtest_filter="*DOCKER*" --gtest_break_on_failure --gtest_shuffle --gtest_repeat=30


Thanks,

Lily Chen


Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35330/#review96798
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Aug. 27, 2015, 11 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35330/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 11 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2797
>     https://issues.apache.org/jira/browse/MESOS-2797
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Capped number of parallel inspect instances on a docker ps call.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/slave/constants.hpp ccfe89c44556de619139551eb988cceebc88bdb5 
> 
> Diff: https://reviews.apache.org/r/35330/diff/
> 
> 
> Testing
> -------
> 
> sudo ./mesos-tests.sh --gtest_filter="*DOCKER*" --gtest_break_on_failure --gtest_shuffle --gtest_repeat=30
> 
> 
> Thanks,
> 
> Lily Chen
> 
>