You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by xueyumusic <gi...@git.apache.org> on 2018/06/22 12:38:52 UTC

[GitHub] flink pull request #6204: [FLINK-4301][docs] add version for quickstart scri...

GitHub user xueyumusic opened a pull request:

    https://github.com/apache/flink/pull/6204

    [FLINK-4301][docs] add version for quickstart script

    
    ## What is the purpose of the change
    This PR add version for quickstart script in the doc
    
    ## Brief change log
    one-line change add version argument
    
    ## Verifying this change
    build doc verified
    
    ## Does this pull request potentially affect one of the following parts:
    no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? docs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xueyumusic/flink addversion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6204
    
----
commit 3ff159e36416b6d824ab2d171f7f179d928971af
Author: xueyu <27...@...>
Date:   2018-06-22T12:29:05Z

    add version for quickstart

----


---

[GitHub] flink issue #6204: [FLINK-4301][docs] add version for quickstart script

Posted by yanghua <gi...@git.apache.org>.

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/6204
  
    @xueyumusic looks good from my side~


---

[GitHub] flink issue #6204: [FLINK-4301][docs] add version for quickstart script

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/6204
  
    Thanks for the pointer @xueyumusic. Now the changes make sense. Merging this PR.


---

[GitHub] flink issue #6204: [FLINK-4301][docs] add version for quickstart script

Posted by xueyumusic <gi...@git.apache.org>.

Github user xueyumusic commented on the issue:

    https://github.com/apache/flink/pull/6204
  
    Thank you for review, @tillrohrmann , it may also need to modify the `quickstart.sh` script which is in another flink-web git project, so I opened another PR at https://github.com/apache/flink-web/pull/111. It seemed  need to modify both places at the same time.


---

[GitHub] flink pull request #6204: [FLINK-4301][docs] add version for quickstart scri...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6204


---