You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Stephen Rufle (JIRA)" <ji...@apache.org> on 2009/01/02 16:23:44 UTC

[jira] Created: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

ShoppingCartServices.loadCartFromOrder setting shipGroups
---------------------------------------------------------

                 Key: OFBIZ-2109
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2109
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
         Environment: Windows XP
            Reporter: Stephen Rufle
             Fix For: SVN trunk


When reloading ship groups from a previously saved order with the following data

OrderItem orderItemSeqId="00001" productId="ABC"
OrderItemShipGroupAssoc orderItemSeqId="00001" shipGroupSeqId="00002"
OrderItemShipGroup shipGroupSeqId="00001" facilityId="AAA"
 
OrderItem orderItemSeqId="00002" productId="ABC"
OrderItemShipGroupAssoc orderItemSeqId="00002" shipGroupSeqId="00001"
OrderItemShipGroup shipGroupSeqId="00002" facilityId="BBB"

The cart.shipInfo var would get reset during the creation of cartItems from orderItems.  My solution was to let the first orderItems loop create all cartItems. Then after that is done loop through orderItems again setting ship groups

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2109:
--------------------------------------

    Assignee: Jacques Le Roux

> ShoppingCartServices.loadCartFromOrder setting shipGroups
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2109
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 2008-12-31_001_shoppingcart.patch, 2008-12-31_001_shoppingcart.patch
>
>
> When reloading ship groups from a previously saved order with the following data
> OrderItem orderItemSeqId="00001" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00001" shipGroupSeqId="00002"
> OrderItemShipGroup shipGroupSeqId="00001" facilityId="AAA"
>  
> OrderItem orderItemSeqId="00002" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00002" shipGroupSeqId="00001"
> OrderItemShipGroup shipGroupSeqId="00002" facilityId="BBB"
> The cart.shipInfo var would get reset during the creation of cartItems from orderItems.  My solution was to let the first orderItems loop create all cartItems. Then after that is done loop through orderItems again setting ship groups

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

Posted by "Stephen Rufle (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662105#action_12662105 ] 

Stephen Rufle commented on OFBIZ-2109:
--------------------------------------

While creating another patch I found that after rev 731851 , typecheckcleanup200810 the current patch no longer applies cleanly. I will try and provide a new patch to replace the current one.


> ShoppingCartServices.loadCartFromOrder setting shipGroups
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2109
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
>            Reporter: Stephen Rufle
>             Fix For: SVN trunk
>
>         Attachments: 2008-12-31_001_shoppingcart.patch
>
>
> When reloading ship groups from a previously saved order with the following data
> OrderItem orderItemSeqId="00001" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00001" shipGroupSeqId="00002"
> OrderItemShipGroup shipGroupSeqId="00001" facilityId="AAA"
>  
> OrderItem orderItemSeqId="00002" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00002" shipGroupSeqId="00001"
> OrderItemShipGroup shipGroupSeqId="00002" facilityId="BBB"
> The cart.shipInfo var would get reset during the creation of cartItems from orderItems.  My solution was to let the first orderItems loop create all cartItems. Then after that is done loop through orderItems again setting ship groups

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666556#action_12666556 ] 

Jacques Le Roux commented on OFBIZ-2109:
----------------------------------------

Thanks Stephen,

Your patch is in trunk at revision: 737041  


> ShoppingCartServices.loadCartFromOrder setting shipGroups
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2109
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 2008-12-31_001_shoppingcart.patch, 2008-12-31_001_shoppingcart.patch
>
>
> When reloading ship groups from a previously saved order with the following data
> OrderItem orderItemSeqId="00001" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00001" shipGroupSeqId="00002"
> OrderItemShipGroup shipGroupSeqId="00001" facilityId="AAA"
>  
> OrderItem orderItemSeqId="00002" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00002" shipGroupSeqId="00001"
> OrderItemShipGroup shipGroupSeqId="00002" facilityId="BBB"
> The cart.shipInfo var would get reset during the creation of cartItems from orderItems.  My solution was to let the first orderItems loop create all cartItems. Then after that is done loop through orderItems again setting ship groups

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2109.
----------------------------------

    Resolution: Fixed

> ShoppingCartServices.loadCartFromOrder setting shipGroups
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2109
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 2008-12-31_001_shoppingcart.patch, 2008-12-31_001_shoppingcart.patch
>
>
> When reloading ship groups from a previously saved order with the following data
> OrderItem orderItemSeqId="00001" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00001" shipGroupSeqId="00002"
> OrderItemShipGroup shipGroupSeqId="00001" facilityId="AAA"
>  
> OrderItem orderItemSeqId="00002" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00002" shipGroupSeqId="00001"
> OrderItemShipGroup shipGroupSeqId="00002" facilityId="BBB"
> The cart.shipInfo var would get reset during the creation of cartItems from orderItems.  My solution was to let the first orderItems loop create all cartItems. Then after that is done loop through orderItems again setting ship groups

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

Posted by "Stephen Rufle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Rufle updated OFBIZ-2109:
---------------------------------

    Attachment: 2008-12-31_001_shoppingcart.patch

Based on 732799 switched to use BigDecimal

> ShoppingCartServices.loadCartFromOrder setting shipGroups
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2109
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
>            Reporter: Stephen Rufle
>             Fix For: SVN trunk
>
>         Attachments: 2008-12-31_001_shoppingcart.patch, 2008-12-31_001_shoppingcart.patch
>
>
> When reloading ship groups from a previously saved order with the following data
> OrderItem orderItemSeqId="00001" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00001" shipGroupSeqId="00002"
> OrderItemShipGroup shipGroupSeqId="00001" facilityId="AAA"
>  
> OrderItem orderItemSeqId="00002" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00002" shipGroupSeqId="00001"
> OrderItemShipGroup shipGroupSeqId="00002" facilityId="BBB"
> The cart.shipInfo var would get reset during the creation of cartItems from orderItems.  My solution was to let the first orderItems loop create all cartItems. Then after that is done loop through orderItems again setting ship groups

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

Posted by "Stephen Rufle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Rufle updated OFBIZ-2109:
---------------------------------

    Attachment: 2008-12-31_001_shoppingcart.patch

Moved shipGroups creation logic out to a new loop

> ShoppingCartServices.loadCartFromOrder setting shipGroups
> ---------------------------------------------------------
>
>                 Key: OFBIZ-2109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2109
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
>            Reporter: Stephen Rufle
>             Fix For: SVN trunk
>
>         Attachments: 2008-12-31_001_shoppingcart.patch
>
>
> When reloading ship groups from a previously saved order with the following data
> OrderItem orderItemSeqId="00001" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00001" shipGroupSeqId="00002"
> OrderItemShipGroup shipGroupSeqId="00001" facilityId="AAA"
>  
> OrderItem orderItemSeqId="00002" productId="ABC"
> OrderItemShipGroupAssoc orderItemSeqId="00002" shipGroupSeqId="00001"
> OrderItemShipGroup shipGroupSeqId="00002" facilityId="BBB"
> The cart.shipInfo var would get reset during the creation of cartItems from orderItems.  My solution was to let the first orderItems loop create all cartItems. Then after that is done loop through orderItems again setting ship groups

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.