You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/26 07:11:06 UTC
[GitHub] [shardingsphere] Swastyy opened a new pull request #12736: Fixes
Swastyy opened a new pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736
Fixes #12569
Changes proposed in this pull request:
-
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736#issuecomment-927258221
@RaigorJiang Do I have to update `docker` and `src` modules in pom file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736#discussion_r716168892
##########
File path: examples/other-example/shardingsphere-parser-example/pom.xml
##########
@@ -25,7 +25,7 @@
<artifactId>shardingsphere-example</artifactId>
Review comment:
parent shoud be other-example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736#issuecomment-927260562
Sorry, there are two more questions:
1. `other-example` is a new module, it also has its own `pom` file, its parent is `shardingsphere-example`, and it has a submodule, `shardingsphere-parser-example`.
2. The parent of `shardingsphere-parser-example` should be updated to `other-example`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736#issuecomment-927249555
Hi @Swastyy
The modules in [pom](https://github.com/apache/shardingsphere/blob/master/examples/pom.xml) file need to update too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736#discussion_r716176277
##########
File path: examples/other-example/shardingsphere-parser-example/pom.xml
##########
@@ -25,7 +25,7 @@
<artifactId>shardingsphere-example</artifactId>
Review comment:
Yes, thank you~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on a change in pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
Swastyy commented on a change in pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736#discussion_r716169554
##########
File path: examples/other-example/shardingsphere-parser-example/pom.xml
##########
@@ -25,7 +25,7 @@
<artifactId>shardingsphere-example</artifactId>
Review comment:
Correct now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy removed a comment on pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
Swastyy removed a comment on pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736#issuecomment-927258221
@RaigorJiang Do I have to update `docker` and `src` modules in pom file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736#issuecomment-927254191
> Hi @Swastyy
> The modules in [pom](https://github.com/apache/shardingsphere/blob/master/examples/pom.xml) file need to update too.
Ohh, I will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #12736: Fixes
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged pull request #12736:
URL: https://github.com/apache/shardingsphere/pull/12736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org