You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/09/27 07:42:37 UTC
[GitHub] [zeppelin] Reamer opened a new pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Reamer opened a new pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235
### What is this PR for?
This PR removes unnecessary calls of maven-dependency-plugin.
### What type of PR is it?
- Improvement
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5541
### How should this be tested?
* CI
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235#issuecomment-929232823
If no other comments are received, I will merge this on Wednesday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235#issuecomment-929295527
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a change in pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235#discussion_r716441898
##########
File path: flink/flink-scala-parent/pom.xml
##########
@@ -862,9 +862,6 @@
<plugin>
<artifactId>maven-enforcer-plugin</artifactId>
</plugin>
- <plugin>
- <artifactId>maven-dependency-plugin</artifactId>
- </plugin>
Review comment:
Inside `pluginManagement` without further use in submodules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235#issuecomment-929232823
If no other comments are received, I will merge this on Wednesday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a change in pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235#discussion_r716440815
##########
File path: zeppelin-interpreter/pom.xml
##########
@@ -231,12 +231,6 @@
<filtering>true</filtering>
</resource>
</resources>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-dependency-plugin</artifactId>
Review comment:
It is not necessary to load all libraries into the destination folder, because we only use the shaded interpreter jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a change in pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235#discussion_r716439732
##########
File path: spark/interpreter/pom.xml
##########
@@ -517,60 +517,6 @@
</execution>
</executions>
</plugin>
-
-
- <plugin>
- <artifactId>maven-dependency-plugin</artifactId>
- <executions>
- <execution>
- <id>copy-dependencies</id>
- <phase>none</phase>
- <configuration>
- <skip>true</skip>
- </configuration>
- </execution>
-
- <execution>
- <id>copy-interpreter-dependencies</id>
- <phase>none</phase>
- <configuration>
- <skip>true</skip>
- </configuration>
- </execution>
- <execution>
- <id>copy-artifact</id>
- <phase>none</phase>
- <configuration>
- <skip>true</skip>
- </configuration>
- </execution>
-
-
- <execution>
- <id>copy-spark-interpreter</id>
- <phase>package</phase>
Review comment:
This copy operation is performed with the maven-shade-plugin.
At the moment we get the following output during the build.
```
2021-09-27T04:39:20.4923321Z [INFO] --- maven-dependency-plugin:3.1.2:copy (copy-spark-interpreter) @ spark-interpreter ---
2021-09-27T04:39:20.4925219Z [INFO] Configured Artifact: org.apache.zeppelin:spark-interpreter:0.11.0-SNAPSHOT:jar
2021-09-27T04:39:20.5007691Z [INFO] org.apache.zeppelin:spark-interpreter:0.11.0-SNAPSHOT:jar already exists in /home/runner/work/zeppelin/zeppelin/spark/interpreter/target/../../../interpreter/spark
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235#issuecomment-929295527
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a change in pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary
Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4235:
URL: https://github.com/apache/zeppelin/pull/4235#discussion_r716438132
##########
File path: spark/interpreter/pom.xml
##########
@@ -517,60 +517,6 @@
</execution>
</executions>
</plugin>
-
-
- <plugin>
- <artifactId>maven-dependency-plugin</artifactId>
- <executions>
- <execution>
- <id>copy-dependencies</id>
Review comment:
A plugin execution which is always skipped is not required.
##########
File path: spark/interpreter/pom.xml
##########
@@ -517,60 +517,6 @@
</execution>
</executions>
</plugin>
-
-
- <plugin>
- <artifactId>maven-dependency-plugin</artifactId>
- <executions>
- <execution>
- <id>copy-dependencies</id>
- <phase>none</phase>
- <configuration>
- <skip>true</skip>
- </configuration>
- </execution>
-
- <execution>
- <id>copy-interpreter-dependencies</id>
- <phase>none</phase>
Review comment:
A plugin execution which is always skipped is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org