You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2024/02/13 16:35:55 UTC
[I] [Task]: Improve how to handle the Dataflow-specific option `impersonateServiceAccount`for Beam Java [beam]
liferoad opened a new issue, #30301:
URL: https://github.com/apache/beam/issues/30301
### What needs to happen?
`impersonateServiceAccount` should be kept when submitting Dataflow jobs but should be removed when creating Dataflow workers per [the design](https://docs.google.com/document/d/13KRYiq5JAcs-leznzXI_knvqp7ud0u3YASVqK-yMeQw/edit#heading=h.18gu8586i6j1). To fix this, #30283 put a simple solution to remove the `impersonateServiceAccount` key from the JSON pipeline options. This introduces some Dataflow-specific options, which could be improved by moving it to the Dataflow-specific module. See more details in [this comment](https://github.com/apache/beam/pull/30283#discussion_r1488065606).
Open this issue to track this potential task to improve how to handle Dataflow-specific options in the future.
Note for Beam Python, we remove this option from [the internal Dataflow apiclient module](https://github.com/apache/beam/blob/b5cfd9523cde3fee8610956682541d4e90ee967b/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py#L280)
### Issue Priority
Priority: 3 (nice-to-have improvement)
### Issue Components
- [ ] Component: Python SDK
- [X] Component: Java SDK
- [ ] Component: Go SDK
- [ ] Component: Typescript SDK
- [ ] Component: IO connector
- [ ] Component: Beam YAML
- [ ] Component: Beam examples
- [ ] Component: Beam playground
- [ ] Component: Beam katas
- [ ] Component: Website
- [ ] Component: Spark Runner
- [ ] Component: Flink Runner
- [ ] Component: Samza Runner
- [ ] Component: Twister2 Runner
- [ ] Component: Hazelcast Jet Runner
- [X] Component: Google Cloud Dataflow Runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task]: Improve how to handle the Dataflow-specific option `impersonateServiceAccount` for Beam Java [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #30301: [Task]: Improve how to handle the Dataflow-specific option `impersonateServiceAccount` for Beam Java
URL: https://github.com/apache/beam/issues/30301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task]: Improve how to handle the Dataflow-specific option `impersonateServiceAccount` for Beam Java [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on issue #30301:
URL: https://github.com/apache/beam/issues/30301#issuecomment-1942165354
For this particular option, the dataflow service (the UW) should be the place where you remove the option.
The Python SDK is a real mess when it comes to isolating non-GCP and GCP things. It is not a good place to use as an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task]: Improve how to handle the Dataflow-specific option `impersonateServiceAccount` for Beam Java [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #30301:
URL: https://github.com/apache/beam/issues/30301#issuecomment-4011564334
This issue has been marked as stale due to 150 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that’s incorrect or this issue still needs to be addressed, please simply write any comment. If closed, you can reopen the issue at any time. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task]: Improve how to handle the Dataflow-specific option `impersonateServiceAccount` for Beam Java [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #30301:
URL: https://github.com/apache/beam/issues/30301#issuecomment-4188841141
This issue has been closed due to lack of activity. If you think that is incorrect, you can reopen the issue at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org