You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/06/02 14:11:04 UTC
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1280:
Java with Maven -> Java Frontend App + MOE is broken since Gradle support
introduced
lkishalmi commented on a change in pull request #1280: Java with Maven -> Java Frontend App + MOE is broken since Gradle support introduced
URL: https://github.com/apache/netbeans/pull/1280#discussion_r289644178
##########
File path: groovy/gradle/src/org/netbeans/modules/gradle/NbGradleProjectFactory.java
##########
@@ -47,24 +47,31 @@
@Override
public boolean isProject(FileObject dir) {
- boolean ret = FileUtil.toFile(dir) != null;
- if (ret) {
- FileObject pom = dir.getFileObject("pom.xml"); //NOI18N
- if ((pom != null) && pom.isData() && GradleSettings.getDefault().isPreferMaven()) {
- ret = false;
- } else {
- File suspect = FileUtil.toFile(dir);
- GradleFiles files = new GradleFiles(suspect);
- if (!files.isRootProject()) {
- Boolean inSubDirCache = GradleProjectCache.isKnownSubProject(files.getRootDir(), suspect);
- ret = inSubDirCache != null ? inSubDirCache : files.isProject();
- } else {
- ret = true;
- }
+ return isProjectCheck(dir, GradleSettings.getDefault().isPreferMaven());
Review comment:
Well in this case, I'd rather like an
if (preferMaven && mavenProjectCheck(...)) return false;
<Gradle Project check>
kind of implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists