[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #56: Support alarm tags

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-query-protocol/pull/56#discussion_r619605745



##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
     scope: Scope
     id: ID!
     message: String!
+    tags: [KeyValue!]!
 }
 
 type Alarms {
     msgs: [AlarmMessage!]!
     total: Int!
 }
 
+input AlarmTag {
+    key: String!
+    value: String
+}
+
 extend type Query {
     getAlarmTrend(duration: Duration!): AlarmTrend!
-    getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!): Alarms
+    getAlarm(duration: Duration!, scope: Scope, keyword: String, paging: Pagination!, tags: [AlarmTag]): Alarms

Review comment:
       If you are asking for this change, please submit another new issue, we need to notify UI side PMC members, and get their approval.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org