You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/06 06:37:05 UTC

[GitHub] [maven] cstamas commented on a diff in pull request #697: [MNG-7360] Fix xml transformation to ensure proper context

cstamas commented on code in PR #697:
URL: https://github.com/apache/maven/pull/697#discussion_r843516695


##########
maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/NodeBufferingParser.java:
##########
@@ -38,44 +37,54 @@
 
     private final List<Event> buffer = new ArrayList<>();
 
-    private final String nodeName;
+    private final ArrayList<String> stack = new ArrayList<>();

Review Comment:
   "... on API edges", yes, but this is totally and fully internal matter/state of implementation, where that mantra above makes sense only in increasing import lines count, nothing more. I don't see this internal `stack` member exposed anywhere, so this is IMHO much better than saying `SuperType stack = new Type` that again, results in +1 import line only, nothing more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org