You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Carlos Sanchez (JIRA)" <ji...@apache.org> on 2007/07/02 22:37:04 UTC
[jira] Created: (JCR-998) Annotation based implementation of
jackrabbit ocm
Annotation based implementation of jackrabbit ocm
-------------------------------------------------
Key: JCR-998
URL: https://issues.apache.org/jira/browse/JCR-998
Project: Jackrabbit
Issue Type: New Feature
Components: jcr-mapping
Reporter: Carlos Sanchez
we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (JCR-998) Annotation based implementation of jackrabbit ocm
Posted by Christophe Lombart <ch...@gmail.com>.
Coooollll ! Thanks for the patch. I'm on vacation for a couple a days but I
will try to commit it on friday.
br,
Christophe
On 7/2/07, Carlos Sanchez (JIRA) <ji...@apache.org> wrote:
>
>
> [
> https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Carlos Sanchez updated JCR-998:
> -------------------------------
>
> Attachment: ocm.patch
>
> Patch needed for jackrabbit-ocm
>
> > Annotation based implementation of jackrabbit ocm
> > -------------------------------------------------
> >
> > Key: JCR-998
> > URL: https://issues.apache.org/jira/browse/JCR-998
> > Project: Jackrabbit
> > Issue Type: New Feature
> > Components: jcr-mapping
> > Reporter: Carlos Sanchez
> > Attachments: ocm-nodemanagement.patch, ocm.patch
> >
> >
> > we have created an annotation based implementation of jackrabbit-ocm
> that can be used instead of the digester one
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Updated: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Sanchez updated JCR-998:
-------------------------------
Attachment: ocm-nodemanagement.patch
Patch needed for jackrabbit-ocm-nodemanagement.
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Attachments: ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Sanchez updated JCR-998:
-------------------------------
Attachment: ocm-nodemanagement.patch
updated patch with correct versions in pom
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Attachments: ocm-nodemanagement.patch, ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Lombart reassigned JCR-998:
--------------------------------------
Assignee: Christophe Lombart
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Assignee: Christophe Lombart
> Attachments: jackrabbit-ocm-annotation.tgz, ocm-nodemanagement.patch, ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518239 ]
Christophe Lombart commented on JCR-998:
----------------------------------------
* I added support for the bean descriptor.
* I dropped the AnnotationObjectContentManagerImpl because we can use the ObjectContentManagerImpl. Only the mapper is different for the annotation support.
* I also modified the annotation attribute names. In order to avoid confusion, it is important to use the same name as the xml file descriptors. Please make suggestions if you think that the names are not correct. the collection annotation has to be modify (should be done this week).
* I added more unit tests (map objects into nt:unstructured). I will add more unit test for mapping on specific node types.
I will continue to work on this issue. I think we can add the following improvements :
* Create an abstract mapper impl because both Mapper classes have a lot of code in common (AnnotedObjectMapper & DigesterMapperImpl).
* The Mapper classes should not have the responsibility to create the jcr node types. This can be done outside the mapper and it should be an optional operation. There are certainly some use cases where node type creation is not necessary.
* I'm just wondering how can we use the same unit tests for both approach (xml file & annotations).
* Can we drop the annotation SuperType. This is defined in the annotation Node (jcrSuperTypes) ?
* Add license headers
Please add your comments and feedback.
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Assignee: Christophe Lombart
> Attachments: jackrabbit-ocm-annotation.tgz, ocm-nodemanagement.patch, ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Sanchez updated JCR-998:
-------------------------------
Attachment: ocm.patch
Patch needed for jackrabbit-ocm
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Attachments: ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510246 ]
Christophe Lombart commented on JCR-998:
----------------------------------------
The class AnnotatedObjectMapper doesn't register the class descriptor which certainly causes this kind of issue.
classDescriptorsRequiringRegistration is empty in the constructor.
I'm going to continue my investigation tomorrow
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Assignee: Christophe Lombart
> Attachments: jackrabbit-ocm-annotation.tgz, ocm-nodemanagement.patch, ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509684 ]
Carlos Sanchez commented on JCR-998:
------------------------------------
there's still the problem that jcr-nodemanagement has not been deployed and the reference to jackrabbit-ocm in its pom is still 1.0-SNAPSHOT instead of 1.4-SNAPSHOT
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Attachments: ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Sanchez updated JCR-998:
-------------------------------
Attachment: jackrabbit-ocm-annotation.tgz
And here it is the important part
If you run the unit test you'll see it fails, we haven't figured out how to deal with collections yet, maybe somebody can figure out what's going on there
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Attachments: jackrabbit-ocm-annotation.tgz, ocm-nodemanagement.patch, ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511578 ]
Christophe Lombart commented on JCR-998:
----------------------------------------
Patch applied - thanks !
The collection issue is still there. I created a more simple unit test because I also detected some issues with namespaces. I continue to work on it.
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Assignee: Christophe Lombart
> Attachments: jackrabbit-ocm-annotation.tgz, ocm-nodemanagement.patch, ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510247 ]
Christophe Lombart commented on JCR-998:
----------------------------------------
OOps maybe it is a normal behavior after a second run. Need more time to investigate.
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Assignee: Christophe Lombart
> Attachments: jackrabbit-ocm-annotation.tgz, ocm-nodemanagement.patch, ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-998) Annotation based implementation of
jackrabbit ocm
Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Lombart resolved JCR-998.
------------------------------------
Resolution: Fixed
the annotation support is done.
> Annotation based implementation of jackrabbit ocm
> -------------------------------------------------
>
> Key: JCR-998
> URL: https://issues.apache.org/jira/browse/JCR-998
> Project: Jackrabbit
> Issue Type: New Feature
> Components: jcr-mapping
> Reporter: Carlos Sanchez
> Assignee: Christophe Lombart
> Attachments: jackrabbit-ocm-annotation.tgz, ocm-nodemanagement.patch, ocm-nodemanagement.patch, ocm.patch
>
>
> we have created an annotation based implementation of jackrabbit-ocm that can be used instead of the digester one
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.