You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/10 02:54:38 UTC

[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new issue #137: Adding X-API-KEY for api request

juzhiyuan opened a new issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137
 
 
   Our API for dashboard is using API Key to auth the request, please add the API Key Header in global request handler. Just like [1] for reference. Please note, this key should be added by `config` file, such as `.env` file. I recommend fetching this key by `fetchAPIKey` API.
   
   [1] https://github.com/apache/incubator-apisix-dashboard/commit/b3b306550e8e5153d42d943d2d652914e2ad88e3#diff-084c3d9c2786b7cd963be84e40a38725R32

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-598546922
 
 
   @sshniro The new dashboard is building on the `next` branch, please use it as base branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] sshniro commented on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-598534523
 
 
   Hi @juzhiyuan I would like to attempt this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan closed issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-598544012
 
 
   @sshniro Please send a PR once you have done this work. Here has some tips: please use the config file instead of hard codes. I would recommend using the env[1] when building.
   
   [1] https://create-react-app.dev/docs/adding-custom-environment-variables/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-599035678
 
 
   Yep, you can use the config file under `/config/` directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan removed a comment on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
juzhiyuan removed a comment on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-596890695
 
 
   https://github.com/apache/incubator-apisix-dashboard/issues/126

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] sshniro edited a comment on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
sshniro edited a comment on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-599023217
 
 
   Hi @juzhiyuan ,
   
   Thank you for the pointers, I was trying to use the config file to expose the Key, can I use the config.ts file inside the config dir or create a new one in the src dir?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-598544012
 
 
   @sshniro Please send a PR once you have done this issue. Here has some tips: please use the config file instead of hard codes, or using the env[1] when building.
   
   [1] https://create-react-app.dev/docs/adding-custom-environment-variables/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-596890695
 
 
   https://github.com/apache/incubator-apisix-dashboard/issues/126

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] sshniro commented on issue #137: Adding X-API-KEY for api request

Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #137: Adding X-API-KEY for api request
URL: https://github.com/apache/incubator-apisix-dashboard/issues/137#issuecomment-599023217
 
 
   Hi @juzhiyuan ,
   
   I was trying to use the config file to expose the Key, can I use the config.ts file inside the config dir or create a new one in the src dir?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services