[GitHub] [commons-vfs] garydgregory commented on a change in pull request #60: VFS-609: VFS SFTP doesn't support a private key as byte array

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #60: VFS-609: VFS SFTP doesn't support a private key as byte array
URL: https://github.com/apache/commons-vfs/pull/60#discussion_r278896534
 
 

 ##########
 File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/IdentityInfo.java
 ##########
 @@ -69,6 +71,43 @@ public IdentityInfo(final File privateKey, final File publicKey, final byte[] pa
         this.privateKey = privateKey;
         this.publicKey = publicKey;
         this.passPhrase = passPhrase;
+        this.privateKeyBytes = null;
+        this.publicKeyBytes = null;
+    }
+
+
+    /**
+     * Constructs an identity info with private and public key and passphrase for the private key.
+     * <p>
+     *
+     * @param privateKey Private key bytes
+     * @param publicKey The public key part used for connections with exchange of certificates (can be {@code null})
+     * @param passPhrase The passphrase to decrypt the private key (can be {@code null} if no passphrase is used)
+     * @since 2.1
 
 Review comment:
   The next version will be 2.4, not 2.1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services