You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Michael Wechner <mi...@wyona.com> on 2005/02/04 14:46:39 UTC
DOMStreamer patched: default namespace and non-empty prefix of attributes
Within Lenya we have encountered a problem with the
o.a.c.xml.dom.DOMStreamer re default namespace and non-empty prefix for
attributes. Thanks to Josias Thoeny the bug has been fixed and I have
checked it into Cocoon-2.1.7-dev (BRANCH_2_1_X)
--- src/java/org/apache/cocoon/xml/dom/DOMStreamer.java (revision 151344)
+++ src/java/org/apache/cocoon/xml/dom/DOMStreamer.java (working copy)
@@ -396,7 +396,7 @@
// if the prefix is null, or the prefix
has not been declared, or conflicts with an in-scope binding
if (declaredUri == null ||
!declaredUri.equals(attrNsURI)) {
String availablePrefix =
currentElementInfo.findPrefix(attrNsURI);
- if (availablePrefix != null)
+ if (availablePrefix != null &&
!availablePrefix.equals(""))
assignedAttrPrefix =
availablePrefix;
else {
Please let us know if there might be a regression.
Thanks
Michi
--
Michael Wechner
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
michael.wechner@wyona.com michi@apache.org
Re: DOMStreamer patched: default namespace and non-empty prefix of
attributes
Posted by Michael Wechner <mi...@wyona.com>.
Vadim Gritsenko wrote:
>>
>>
>> btw, the trunk builds successfully but doesn't seem to work
>>
>> java.lang.IllegalStateException: ConnectionFactoryAvalonDataSource is
>> already initialized
>
>
> I guess it is either my fault or problem with the new core... I can
> take a look at it but not sooner then mon/tue...
no problem
have a nice weekend
Michi
--
Michael Wechner
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
michael.wechner@wyona.com michi@apache.org
Re: DOMStreamer patched: default namespace and non-empty prefix of
attributes
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Michael Wechner wrote:
> Ugo Cei wrote:
>
>> Il giorno 04/feb/05, alle 15:30, Vadim Gritsenko ha scritto:
>>
>>> What about trunk? Is it already there, or you are waiting on
>>> something? Just don't want it to get out of sink,
>>
>>
>
> ok, patched it within the trunk, whereas I noticed that trunk and
> BRANCH_2_1_X are not in sync re "static".
>
> btw, the trunk builds successfully but doesn't seem to work
>
> java.lang.IllegalStateException: ConnectionFactoryAvalonDataSource is
> already initialized
I guess it is either my fault or problem with the new core... I can take a look
at it but not sooner then mon/tue...
Vadim
Re: DOMStreamer patched: default namespace and non-empty prefix of
attributes
Posted by Michael Wechner <mi...@wyona.com>.
Ugo Cei wrote:
> Il giorno 04/feb/05, alle 15:30, Vadim Gritsenko ha scritto:
>
>> What about trunk? Is it already there, or you are waiting on
>> something? Just don't want it to get out of sink,
>
ok, patched it within the trunk, whereas I noticed that trunk and
BRANCH_2_1_X are not in sync re "static".
btw, the trunk builds successfully but doesn't seem to work
java.lang.IllegalStateException: ConnectionFactoryAvalonDataSource is already initialized
Michi
--
Michael Wechner
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
michael.wechner@wyona.com michi@apache.org
Re: DOMStreamer patched: default namespace and non-empty prefix of
attributes
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Ugo Cei wrote:
> Il giorno 04/feb/05, alle 15:30, Vadim Gritsenko ha scritto:
>
>> What about trunk? Is it already there, or you are waiting on
>> something? Just don't want it to get out of sink,
>
>
> I don't want to know what is it that you're doing in your kitchen, but
> getting a trunk in and out of the sink sounds strange.
>
> Ugo
>
> P.S.: sorry, couldn't resist ;)
LOL
Vadim
Re: DOMStreamer patched: default namespace and non-empty prefix of attributes
Posted by Ugo Cei <ug...@apache.org>.
Il giorno 04/feb/05, alle 15:30, Vadim Gritsenko ha scritto:
> What about trunk? Is it already there, or you are waiting on
> something? Just don't want it to get out of sink,
I don't want to know what is it that you're doing in your kitchen, but
getting a trunk in and out of the sink sounds strange.
Ugo
P.S.: sorry, couldn't resist ;)
--
Ugo Cei - http://agylen.com/blojsom/blog/
Re: DOMStreamer patched: default namespace and non-empty prefix of
attributes
Posted by Michael Wechner <mi...@wyona.com>.
Vadim Gritsenko wrote:
> Michael Wechner wrote:
>
>> Within Lenya we have encountered a problem with the
>> o.a.c.xml.dom.DOMStreamer re default namespace and non-empty prefix
>> for attributes. Thanks to Josias Thoeny the bug has been fixed and I
>> have checked it into Cocoon-2.1.7-dev (BRANCH_2_1_X)
>
>
> What about trunk?
I didn't patch it within the trunk
> Is it already there, or you are waiting on something?
waiting, to get some feedback ;-)
> Just don't want it to get out of sink,
ok, shall I also patch it within the trunk?
Michi
>
>
> Regards,
> Vadim
>
--
Michael Wechner
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
michael.wechner@wyona.com michi@apache.org
Re: DOMStreamer patched: default namespace and non-empty prefix of
attributes
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Michael Wechner wrote:
> Within Lenya we have encountered a problem with the
> o.a.c.xml.dom.DOMStreamer re default namespace and non-empty prefix for
> attributes. Thanks to Josias Thoeny the bug has been fixed and I have
> checked it into Cocoon-2.1.7-dev (BRANCH_2_1_X)
What about trunk? Is it already there, or you are waiting on something? Just
don't want it to get out of sink,
Regards,
Vadim