You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "andreydevyatkin (via GitHub)" <gi...@apache.org> on 2023/06/23 15:45:36 UTC
[GitHub] [beam] andreydevyatkin opened a new pull request, #27233: Migrate "beam_PreCommit_Java_Examples_Dataflow" Jenkins job to Github Actions
andreydevyatkin opened a new pull request, #27233:
URL: https://github.com/apache/beam/pull/27233
The following jenkins jobs have been migrated:
- https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Commit/
- https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/
- https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Phrase/
### How has it been tested?
The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
- by creating pull requests with changes in trigger paths
- by adding a comment to the PR
- by making a push
<img width="1666" alt="image" src="https://github.com/apache/beam/assets/38127224/375c49f6-91ee-4a18-8847-b27dc960a9dd">
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27233: Migrate "beam_PreCommit_Java_Examples_Dataflow" Jenkins job to Github Actions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27233:
URL: https://github.com/apache/beam/pull/27233#issuecomment-1604495800
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #27233: Migrate "beam_PreCommit_Java_Examples_Dataflow" Jenkins job to Github Actions
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #27233:
URL: https://github.com/apache/beam/pull/27233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #27233: Migrate "beam_PreCommit_Java_Examples_Dataflow" Jenkins job to Github Actions
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27233:
URL: https://github.com/apache/beam/pull/27233#discussion_r1248279677
##########
.github/workflows/beam_PreCommit_Java_Examples_Dataflow.yml:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PreCommit Java Examples Dataflow
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['model/**', 'sdks/java/**', 'runners/google-cloud-dataflow-java/**', 'examples/java/**', 'examples/kotlin/**', 'release/**']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: ['model/**', 'sdks/java/**', 'runners/google-cloud-dataflow-java/**', 'examples/java/**', 'examples/kotlin/**', 'release/**']
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '* */6 * * *'
+
+permissions: read-all
+jobs:
+ check_gcp_variables:
+ timeout-minutes: 5
+ name: check_gcp_variables
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ gcp-variables-set: ${{ steps.check_gcp_variables.outputs.gcp-variables-set }}
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ - name: Check are GCP variables set
Review Comment:
Since we're using `pull_request_target`, do we need this job? All of these secrets will be set no matter what given the triggers, right?
##########
.github/workflows/beam_PreCommit_Java_Examples_Dataflow.yml:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PreCommit Java Examples Dataflow
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['model/**', 'sdks/java/**', 'runners/google-cloud-dataflow-java/**', 'examples/java/**', 'examples/kotlin/**', 'release/**']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: ['model/**', 'sdks/java/**', 'runners/google-cloud-dataflow-java/**', 'examples/java/**', 'examples/kotlin/**', 'release/**']
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '* */6 * * *'
+
+permissions: read-all
+jobs:
+ check_gcp_variables:
+ timeout-minutes: 5
+ name: check_gcp_variables
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ gcp-variables-set: ${{ steps.check_gcp_variables.outputs.gcp-variables-set }}
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ - name: Check are GCP variables set
+ run: "./scripts/ci/ci_check_are_gcp_variables_set.sh"
+ id: check_gcp_variables
+ env:
+ GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }}
+ GCP_SA_EMAIL: ${{ secrets.GCP_SA_EMAIL }}
+ GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }}
+ GCP_TESTING_BUCKET: ${{ secrets.GCP_TESTING_BUCKET }}
+ GCP_REGION: "not-needed-here"
+ GCP_PYTHON_WHEELS_BUCKET: "not-needed-here"
+
+ beam_PreCommit_Java_Examples_Dataflow:
+ name: beam_PreCommit_Java_Examples_Dataflow
+ needs:
+ - check_gcp_variables
+ runs-on: [self-hosted, ubuntu-20.04]
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event.comment.body == 'Run Java_Examples_Dataflow PreCommit'
Review Comment:
Do we need to add the rerun action as a step somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andreydevyatkin commented on a diff in pull request #27233: Migrate "beam_PreCommit_Java_Examples_Dataflow" Jenkins job to Github Actions
Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on code in PR #27233:
URL: https://github.com/apache/beam/pull/27233#discussion_r1255942360
##########
.github/workflows/beam_PreCommit_Java_Examples_Dataflow.yml:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PreCommit Java Examples Dataflow
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['model/**', 'sdks/java/**', 'runners/google-cloud-dataflow-java/**', 'examples/java/**', 'examples/kotlin/**', 'release/**']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: ['model/**', 'sdks/java/**', 'runners/google-cloud-dataflow-java/**', 'examples/java/**', 'examples/kotlin/**', 'release/**']
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '* */6 * * *'
+
+permissions: read-all
+jobs:
+ check_gcp_variables:
+ timeout-minutes: 5
+ name: check_gcp_variables
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ gcp-variables-set: ${{ steps.check_gcp_variables.outputs.gcp-variables-set }}
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ - name: Check are GCP variables set
Review Comment:
Removed
##########
.github/workflows/beam_PreCommit_Java_Examples_Dataflow.yml:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PreCommit Java Examples Dataflow
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['model/**', 'sdks/java/**', 'runners/google-cloud-dataflow-java/**', 'examples/java/**', 'examples/kotlin/**', 'release/**']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: ['model/**', 'sdks/java/**', 'runners/google-cloud-dataflow-java/**', 'examples/java/**', 'examples/kotlin/**', 'release/**']
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '* */6 * * *'
+
+permissions: read-all
+jobs:
+ check_gcp_variables:
+ timeout-minutes: 5
+ name: check_gcp_variables
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ gcp-variables-set: ${{ steps.check_gcp_variables.outputs.gcp-variables-set }}
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ - name: Check are GCP variables set
+ run: "./scripts/ci/ci_check_are_gcp_variables_set.sh"
+ id: check_gcp_variables
+ env:
+ GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }}
+ GCP_SA_EMAIL: ${{ secrets.GCP_SA_EMAIL }}
+ GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }}
+ GCP_TESTING_BUCKET: ${{ secrets.GCP_TESTING_BUCKET }}
+ GCP_REGION: "not-needed-here"
+ GCP_PYTHON_WHEELS_BUCKET: "not-needed-here"
+
+ beam_PreCommit_Java_Examples_Dataflow:
+ name: beam_PreCommit_Java_Examples_Dataflow
+ needs:
+ - check_gcp_variables
+ runs-on: [self-hosted, ubuntu-20.04]
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event.comment.body == 'Run Java_Examples_Dataflow PreCommit'
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27233: Migrate "beam_PreCommit_Java_Examples_Dataflow" Jenkins job to Github Actions
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27233:
URL: https://github.com/apache/beam/pull/27233#issuecomment-1625613435
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27233](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b73b3c3) into [master](https://app.codecov.io/gh/apache/beam/commit/f19c384af1f1952df60162ee70ce0f1cb3621a7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f19c384) will **increase** coverage by `9.21%`.
> The diff coverage is `28.88%`.
> :exclamation: Current head b73b3c3 differs from pull request most recent head 063b01f. Consider uploading reports for the commit 063b01f to get more accurate results
```diff
@@ Coverage Diff @@
## master #27233 +/- ##
==========================================
+ Coverage 71.05% 80.27% +9.21%
==========================================
Files 858 563 -295
Lines 104105 68069 -36036
==========================================
- Hits 73976 54640 -19336
+ Misses 28580 13429 -15151
+ Partials 1549 0 -1549
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `?` | |
| python | `80.27% <28.88%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/apache\_beam/examples/complete/game/user\_score.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS91c2VyX3Njb3JlLnB5) | `62.79% <ø> (ø)` | |
| [...m/examples/inference/runinference\_metrics/setup.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvaW5mZXJlbmNlL3J1bmluZmVyZW5jZV9tZXRyaWNzL3NldHVwLnB5) | `0.00% <ø> (ø)` | |
| [...amples/inference/vertex\_ai\_image\_classification.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvaW5mZXJlbmNlL3ZlcnRleF9haV9pbWFnZV9jbGFzc2lmaWNhdGlvbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/gcp/bigtableio.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3RhYmxlaW8ucHk=) | `74.62% <ø> (ø)` | |
| [sdks/python/apache\_beam/io/gcp/gcsfilesystem.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2ZpbGVzeXN0ZW0ucHk=) | `89.06% <ø> (ø)` | |
| [sdks/python/apache\_beam/io/gcp/gcsio.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvLnB5) | `66.66% <ø> (ø)` | |
| [...on/apache\_beam/ml/inference/vertex\_ai\_inference.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvaW5mZXJlbmNlL3ZlcnRleF9haV9pbmZlcmVuY2UucHk=) | `0.00% <ø> (ø)` | |
| [sdks/python/apache\_beam/ml/transforms/base.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvdHJhbnNmb3Jtcy9iYXNlLnB5) | `81.08% <ø> (ø)` | |
| [sdks/python/apache\_beam/ml/transforms/handlers.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvdHJhbnNmb3Jtcy9oYW5kbGVycy5weQ==) | `7.00% <ø> (ø)` | |
| [sdks/python/apache\_beam/ml/transforms/tft.py](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvdHJhbnNmb3Jtcy90ZnQucHk=) | `6.97% <ø> (ø)` | |
| ... and [24 more](https://app.codecov.io/gh/apache/beam/pull/27233?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [300 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27233/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org