You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/03 12:40:14 UTC
[GitHub] [flink] MartijnVisser opened a new pull request #18257: [FLINK-25504][Kafka] Upgrade Confluent to v6.2.2 and Kafka-Client to …
MartijnVisser opened a new pull request #18257:
URL: https://github.com/apache/flink/pull/18257
…2.8.1
## What is the purpose of the change
The Flink codebases uses Kafka Client and Confluent Platform in multiple places:
- AVRO Confluent Schema Registry
- Flink end-to-end tests (Bash e2e tests)
- Flink end-to-end tests common (Java e2e tests)
- SQL AVRO Confluent Schema Registry
- Flink Test Utils
- Flink Tests
The used versions are currently not in sync, which could result in unexpected results.
## Brief change log
* Updated `flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml` from Confluent Platform 5.5.2 to 6.2.2 and Kafka Client from 2.4.1 to 2.8.1
* Updated `flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java` and `flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/StreamingKafkaITCase.java` from Kafka Client 2.4.1 to 2.8.1
* Updated `flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientSchemaRegistryITCase.java` from Confluent Platform 5.5.2 to 6.2.2
* Updated `flink-end-to-end-tests/pom.xml` to skip dependency convergence due to Guava, else the CI build will fail due to:
```
Dependency convergence error for com.google.guava:guava:30.1.1-jre paths to dependency are:
+-org.apache.flink:flink-end-to-end-tests-common-kafka:1.15-SNAPSHOT
+-io.confluent:kafka-schema-registry-client:6.2.2
+-com.google.guava:guava:30.1.1-jre
and
+-org.apache.flink:flink-end-to-end-tests-common-kafka:1.15-SNAPSHOT
+-org.apache.flink:flink-connector-testing:1.15-SNAPSHOT
+-org.apache.flink:flink-test-utils:1.15-SNAPSHOT
+-org.apache.curator:curator-test:2.12.0
+-com.google.guava:guava:16.0.1
```
* Updated `flink-end-to-end-tests/test-scripts/test_confluent_schema_registry.sh` from Kafka Client 2.6.0 to 2.8.1 and Confluent Platform from 6.0.4 to 6.2.2
* Updated `flink-end-to-end-tests/test-scripts/test_pyflink.sh` from Kafka Client 2.2.0 to 2.8.1 and Confluent Platform from 5.2.6 to 6.2.2
* Updated `flink-end-to-end-tests/test-scripts/test_sql_client.sh` from Kafka Client 2.2.2 to 2.8.1 and Confluent Platform 5.2.6 to 6.2.2
* Updated `flink-formats/flink-avro-confluent-registry/pom.xml` from Kafka Client 2.4.1 to 2.8.1 and Confluent Platform from 5.5.2 to 6.2.2
* Updated `flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java` testcontainers version for Confluent Platform from 6.2.1 to 6.2.2
* Updated `flink-formats/flink-sql-avro-confluent-registry/src/main/resources/META-INF/NOTICE` license information from 5.5.2 to 6.2.2 for Kafka Client dependencies
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96be28b75d073bf500853880dffb5aeffd9113cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866",
"triggerID" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"triggerType" : "PUSH"
}, {
"hash" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96be28b75d073bf500853880dffb5aeffd9113cb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866)
* b0ee990cadde9f9ea473f73900538da33f99e05d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866",
"triggerID" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"triggerType" : "PUSH"
}, {
"hash" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29232",
"triggerID" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"triggerType" : "PUSH"
}, {
"hash" : "7a1538d7b068af74613381a201fd66eafcb6bb17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a1538d7b068af74613381a201fd66eafcb6bb17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0ee990cadde9f9ea473f73900538da33f99e05d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29232)
* 7a1538d7b068af74613381a201fd66eafcb6bb17 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866",
"triggerID" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"triggerType" : "PUSH"
}, {
"hash" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29232",
"triggerID" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"triggerType" : "PUSH"
}, {
"hash" : "7a1538d7b068af74613381a201fd66eafcb6bb17",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29392",
"triggerID" : "7a1538d7b068af74613381a201fd66eafcb6bb17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0ee990cadde9f9ea473f73900538da33f99e05d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29232)
* 7a1538d7b068af74613381a201fd66eafcb6bb17 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29392)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067125
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cbf05d98b3ea1ab16710e0c07e705e0c7ade9b44 (Mon Jan 03 12:44:17 UTC 2022)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25504).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #18257:
URL: https://github.com/apache/flink/pull/18257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18257:
URL: https://github.com/apache/flink/pull/18257#discussion_r782916597
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -216,14 +216,31 @@ under the License.
<artifactItem>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
- <version>2.4.1</version>
+ <version>2.8.1</version>
<destFileName>kafka-clients.jar</destFileName>
<type>jar</type>
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
</artifactItem>
</artifactItems>
</configuration>
</plugin>
+
+ <!-- Skip dependency convergence check because of guava version -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>dependency-convergence</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
why not just fix the convergence issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18257:
URL: https://github.com/apache/flink/pull/18257#discussion_r778854403
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -216,14 +216,31 @@ under the License.
<artifactItem>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
- <version>2.4.1</version>
+ <version>2.8.1</version>
<destFileName>kafka-clients.jar</destFileName>
<type>jar</type>
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
</artifactItem>
</artifactItems>
</configuration>
</plugin>
+
+ <!-- Skip dependency convergence check because of guava version -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>dependency-convergence</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
@zentol although we also used it in kinesis for some reason what would be the right way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbf05d98b3ea1ab16710e0c07e705e0c7ade9b44",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cbf05d98b3ea1ab16710e0c07e705e0c7ade9b44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbf05d98b3ea1ab16710e0c07e705e0c7ade9b44 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18257:
URL: https://github.com/apache/flink/pull/18257#discussion_r782918831
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -216,14 +216,31 @@ under the License.
<artifactItem>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
- <version>2.4.1</version>
+ <version>2.8.1</version>
<destFileName>kafka-clients.jar</destFileName>
<type>jar</type>
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
</artifactItem>
</artifactItems>
</configuration>
</plugin>
+
+ <!-- Skip dependency convergence check because of guava version -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>dependency-convergence</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
I don't know why we skip convergence for kinesis. It doesn't sound like a good idea to me because guava might be bundled, and there we should take care we pick the right one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1012779888
NB: Flinkbot reports as the CI still `PENDING`, but it has completed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1009934168
I had to fix merge conflicts after https://github.com/apache/flink/pull/18105 was merged, but all is good again. Only waiting for @zentol feedback with regards to the dependency convergence approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866",
"triggerID" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96be28b75d073bf500853880dffb5aeffd9113cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1012968641
@MartijnVisser can you also open a ticket to update it for the kinesis e2e tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18257:
URL: https://github.com/apache/flink/pull/18257#discussion_r783919174
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -216,14 +216,31 @@ under the License.
<artifactItem>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
- <version>2.4.1</version>
+ <version>2.8.1</version>
<destFileName>kafka-clients.jar</destFileName>
<type>jar</type>
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
</artifactItem>
</artifactItems>
</configuration>
</plugin>
+
+ <!-- Skip dependency convergence check because of guava version -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>dependency-convergence</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
I've excluded `com.google.guava:guava` from `org.apache.flink:flink-connector-testing` in `flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml` and removed the convergence check. The CI passed locally, so let's see if this resolves it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18257:
URL: https://github.com/apache/flink/pull/18257#discussion_r784705632
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -143,6 +143,12 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-testing</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866",
"triggerID" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"triggerType" : "PUSH"
}, {
"hash" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29232",
"triggerID" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0ee990cadde9f9ea473f73900538da33f99e05d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29232)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866",
"triggerID" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"triggerType" : "PUSH"
}, {
"hash" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29232",
"triggerID" : "b0ee990cadde9f9ea473f73900538da33f99e05d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96be28b75d073bf500853880dffb5aeffd9113cb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866)
* b0ee990cadde9f9ea473f73900538da33f99e05d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29232)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18257:
URL: https://github.com/apache/flink/pull/18257#discussion_r777533971
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -216,14 +216,31 @@ under the License.
<artifactItem>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
- <version>2.4.1</version>
+ <version>2.8.1</version>
<destFileName>kafka-clients.jar</destFileName>
<type>jar</type>
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
</artifactItem>
</artifactItems>
</configuration>
</plugin>
+
+ <!-- Skip dependency convergence check because of guava version -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>dependency-convergence</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
I've based this on the same implementation as in `flink-end-to-end-tests/flink-streaming-kinesis-test/pom.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18257:
URL: https://github.com/apache/flink/pull/18257#issuecomment-1004067332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866",
"triggerID" : "96be28b75d073bf500853880dffb5aeffd9113cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96be28b75d073bf500853880dffb5aeffd9113cb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28866)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org