You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2017/05/24 00:29:03 UTC
[Bug 61119] New: Fix preset shape rendering
https://bz.apache.org/bugzilla/show_bug.cgi?id=61119
Bug ID: 61119
Summary: Fix preset shape rendering
Product: POI
Version: 3.17-dev
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: SL Common
Assignee: dev@poi.apache.org
Reporter: kiwiwings@apache.org
Target Milestone: ---
Created attachment 35006
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35006&action=edit
Test file for preset definitions
The rendering of the preset shapes has actually quite some errors.
The main problem is connected with the way arcs are displayed in AWT [1], i.e.
> angles are specified relative to the non-square framing rectangle
> such that 45 degrees always falls on the line from the center of
> the ellipse to the upper right corner of the framing rectangle
Additional the old code used Math.atan() where it should use Math.atan2(),
which also covers the cases on the other side of the axis.
And ArcTanExpression actually should return a OOXML angle.
[1] https://docs.oracle.com/javase/6/docs/api/java/awt/geom/Arc2D.html
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 61119] Fix preset shape rendering
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61119
--- Comment #1 from Andreas Beeker <ki...@apache.org> ---
Created attachment 35007
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35007&action=edit
Geometry patch (preview)
This is a preview of a not-to far commit.
Currently I'm also looking into supporting different shadings which are used in
the preset shapes ...
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 61119] Fix preset shape rendering and shading
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61119
Andreas Beeker <ki...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Andreas Beeker <ki...@apache.org> ---
applied with r1796823
Thanks to Michael Ford for bringing this up
- Fixed conversion of ooxml to awt angle
- replace subclasses and reflection calls with enums
- implemented tinting/shading of preset shapes
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 61119] Fix preset shape rendering and shading
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61119
Andreas Beeker <ki...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Fix preset shape rendering |Fix preset shape rendering
| |and shading
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org