You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/19 11:51:00 UTC

[jira] [Commented] (FLINK-9895) Ensure correct logging settings for NettyLeakDetectionResource

    [ https://issues.apache.org/jira/browse/FLINK-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549171#comment-16549171 ] 

ASF GitHub Bot commented on FLINK-9895:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6374

    [FLINK-9895][tests] Ensure error logging for NettyLeakDetectionResource

    ## What is the purpose of the change
    
    This PR is a small addition to #6363 to ensure that ERROR logging is enabled for Nettys `ResourceLeakDetector`, as otherwise the the leak will not cause test failures.
    
    ## Verifying this change
    
    * disable error logging in `flink-runtime` for `ResourceLeakDetector`. (see `log4j-test.properties`)
    * disable auto-release in `FileUploadHandler`
    * run `FileUploadHandlerTest`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9895

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6374
    
----
commit 373d6ef65b50de86897a9da6d403982aae59a3d1
Author: zentol <ch...@...>
Date:   2018-07-19T11:47:53Z

    [FLINK-9895][tests] Ensure error logging for NettyLeakDetectionResource

----


> Ensure correct logging settings for NettyLeakDetectionResource
> --------------------------------------------------------------
>
>                 Key: FLINK-9895
>                 URL: https://issues.apache.org/jira/browse/FLINK-9895
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> The {{NettyLeakDetectionResource}} only works properly if ERROR logging is enabled for nettys {{ResourceLeakDetector}}. We should add an assertion to the resource constructor to ensure this is actually set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)