You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/08/27 22:52:34 UTC
[GitHub] [groovy] paulk-asert opened a new pull request #1356: GROOVY-9702: make ASTTest value optional (from a JDK bytecode perspec…
paulk-asert opened a new pull request #1356:
URL: https://github.com/apache/groovy/pull/1356
…tive)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1356: GROOVY-9702: make ASTTest value optional (from a JDK bytecode perspec…
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1356:
URL: https://github.com/apache/groovy/pull/1356#issuecomment-682231062
@eric-milles To avoid the breaking change on 3_0_X, would something like this keep the IDE happy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1356: GROOVY-9702: make ASTTest value optional (from a JDK bytecode perspec…
Posted by GitBox <gi...@apache.org>.
eric-milles commented on pull request #1356:
URL: https://github.com/apache/groovy/pull/1356#issuecomment-682250429
@paulk-asert What is the breaking change? I'm doubtful anyone relies on runtime retention since the implementation is to read the closure literal's source text and execute that as a script. You can't even add the arrow to the closure expression without it failing. There is nothing about the compiled result that is used by ASTTestTransformation. Only if someone used the ASTTest annotation afterwards for some other purpose would this be a breaking change.
It is okay not to merge back into earlier Groovy versions if you are at all concerned. This particular change would stop the IDE from giving a warning if you fail to supply a closure, so I don't think it is desirable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1356: GROOVY-9702: make ASTTest value optional (from a JDK bytecode perspec…
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1356:
URL: https://github.com/apache/groovy/pull/1356#issuecomment-682433893
@eric-milles Okay, I'll work on an alternative. Just setting the value to a "nulled out" closure expression as per your PR now merged on the master branch isn't good enough if we leave the retention as RUNTIME. And agreed its a very minor breaking change - so I will document it as such in the release notes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert closed pull request #1356: GROOVY-9702: make ASTTest value optional (from a JDK bytecode perspec…
Posted by GitBox <gi...@apache.org>.
paulk-asert closed pull request #1356:
URL: https://github.com/apache/groovy/pull/1356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org