You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (Created) (JIRA)" <ji...@apache.org> on 2011/10/09 08:46:29 UTC
[jira] [Created] (HBASE-4558) Refactor TestOpenedRegionHandler and
TestOpenRegionHandler.
Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
-----------------------------------------------------------
Key: HBASE-4558
URL: https://issues.apache.org/jira/browse/HBASE-4558
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4558) Refactor TestOpenedRegionHandler and
TestOpenRegionHandler.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4558:
------------------------------------------
Fix Version/s: 0.92.0
Status: Patch Available (was: Open)
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126343#comment-13126343 ]
ramkrishna.s.vasudevan commented on HBASE-4558:
-----------------------------------------------
@Stack
Though we start the minicluster inside the testcase the minicluster shutdown is called in teardown. That will for sure shutdown the cluster.
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128385#comment-13128385 ]
Hudson commented on HBASE-4558:
-------------------------------
Integrated in HBase-TRUNK #2325 (See [https://builds.apache.org/job/HBase-TRUNK/2325/])
HBASE-4558 - Addendum for TestMasterFailOver (Ram)
HBASE-4558 Refactor TestOpenedRegionHandler and TestOpenRegionHandler. (Ram)
ramkrishna :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
ramkrishna :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockServer.java
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch, HBASE-4558_3.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126373#comment-13126373 ]
Jonathan Gray commented on HBASE-4558:
--------------------------------------
- metaRegion, regionServer);
+ metaRegion, regionServer.getServerName());
?
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch, HBASE-4558_3.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4558) Refactor TestOpenedRegionHandler and
TestOpenRegionHandler.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4558:
------------------------------------------
Attachment: HBASE-4558_3.patch
Added a try finally block.
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch, HBASE-4558_3.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126372#comment-13126372 ]
Jonathan Gray commented on HBASE-4558:
--------------------------------------
Did this break the build? TestMasterFailover is not compiling for me.
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch, HBASE-4558_3.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4558) Refactor TestOpenedRegionHandler and
TestOpenRegionHandler.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4558:
------------------------------------------
Status: Open (was: Patch Available)
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125959#comment-13125959 ]
Ted Yu commented on HBASE-4558:
-------------------------------
+1 on patch v2.
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126404#comment-13126404 ]
ramkrishna.s.vasudevan commented on HBASE-4558:
-----------------------------------------------
@Jon
Yes. sorry for that ..will correct that immediately.
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch, HBASE-4558_3.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126461#comment-13126461 ]
Hudson commented on HBASE-4558:
-------------------------------
Integrated in HBase-0.92 #60 (See [https://builds.apache.org/job/HBase-0.92/60/])
HBASE-4558 - Addendum for TestMasterFailover (Ram)
HBASE-4558 Refactor TestOpenedRegionHandler and TestOpenRegionHandler. (Ram)
ramkrishna :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
ramkrishna :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockServer.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/MockServer.java
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch, HBASE-4558_3.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125576#comment-13125576 ]
Ted Yu commented on HBASE-4558:
-------------------------------
Patch looks good.
{code}
+ // Should not invoke assignmentmanager.regionOnline. If it invokes as per
+ // the
+ // current mocking we have done it will throw null pointer.
{code}
'the' in the middle is not needed. How about the following ?
{code}
+ // Should not invoke assignmentmanager.regionOnline. If it is invoked as per
+ // current mocking it will throw null pointer exception.
{code}
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4558) Refactor TestOpenedRegionHandler and
TestOpenRegionHandler.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4558:
------------------------------------------
Attachment: HBASE-4558_2.patch
New patch uploaded addressing Ted's comment.
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4558) Refactor TestOpenedRegionHandler and
TestOpenRegionHandler.
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4558:
-------------------------
Status: Patch Available (was: Open)
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126017#comment-13126017 ]
stack commented on HBASE-4558:
------------------------------
In testOpenedRegionHandlerOnMasterRestart, after you start the cluster, do you open a try so you can catch any exceptions and for sure shutdown the cluster in a finally block? If not, add on commit.
+1 on commit. Thanks for making this fix Ram.
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
and TestOpenRegionHandler.
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126768#comment-13126768 ]
Lars Hofhansl commented on HBASE-4558:
--------------------------------------
I don't think the addendum needs to be mentioned in CHANGES.txt. A user looking at the set of changes won't care :)
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch, HBASE-4558_3.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4558) Refactor TestOpenedRegionHandler and
TestOpenRegionHandler.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4558:
------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Resolved in trunk and 0.92
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch, HBASE-4558_3.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4558) Refactor TestOpenedRegionHandler and
TestOpenRegionHandler.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4558:
------------------------------------------
Attachment: HBASE-4558_1.patch
Refactors MockServer and MockRegionServer to org.apache.hadoop.hbase.util package.
TestOpenedRegionHandler.testShouldNotCompeleteOpenedRegionSuccessfullyIfVersionMismatches() now will not use the mini cluster except for minizkCluster.
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
> Key: HBASE-4558
> URL: https://issues.apache.org/jira/browse/HBASE-4558
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4558_1.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira