You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/05 05:31:53 UTC

[GitHub] [skywalking] AirTrioa opened a new pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

AirTrioa opened a new pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   When some older projects (using Oracle database) access skywalking, we find that the port and database name of Oracle are incorrectly identified. The port is recognized as 1521 by default and the database name is recognized as < port > / < dbname >.
   We found that when we cut the Oracle URL, we only recognize the URL of one sid connection mode (jdbc: oracle: thin: @ < host >: < port >: < Sid >); so here I added the recognition of the URL of another sidsid connection mode (jdbc: oracle: thin: @ < host >: < port > / < Sid >).
   
   - How to fix?
   An if branch is added before setting the default port.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#discussion_r375071553
 
 

 ##########
 File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/OracleURLParser.java
 ##########
 @@ -94,6 +94,10 @@ private ConnectionInfo commonsURLParse() {
         String[] hostSegment = splitDatabaseAddress(host);
         String databaseName = fetchDatabaseNameFromURL();
         if (hostSegment.length == 1) {
+            if (databaseName.contains("/") && databaseName.split("/").length == 2) {
+                String[] portAndDatabaseName = databaseName.split("/");
+                return new ConnectionInfo(ComponentsDefine.OJDBC, DB_TYPE, host, Integer.valueOf(portAndDatabaseName[0]), portAndDatabaseName[1]);
+            }
 
 Review comment:
   Where is the `else`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#issuecomment-582259358
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=h1) Report
   > Merging [#4320](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6aadb29c4fbff603828b35ff6091c4931bc27230?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `77.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4320/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4320      +/-   ##
   ==========================================
   + Coverage   27.12%   27.13%   +0.01%     
   ==========================================
     Files        1175     1175              
     Lines       25616    25616              
     Branches     3646     3646              
   ==========================================
   + Hits         6948     6952       +4     
   + Misses      18061    18060       -1     
   + Partials      607      604       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | :arrow_up: |
   | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...vation/opentracing/span/SpanSetTagInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1vcGVudHJhY2luZy1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vb3BlbnRyYWNpbmcvc3Bhbi9TcGFuU2V0VGFnSW50ZXJjZXB0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [.../customize/interceptor/BaseInterceptorMethods.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9jdXN0b21pemUtZW5oYW5jZS1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jdXN0b21pemUvaW50ZXJjZXB0b3IvQmFzZUludGVyY2VwdG9yTWV0aG9kcy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...walking/apm/plugin/elasticsearch/v5/Constants.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZWxhc3RpY3NlYXJjaC01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZWxhc3RpY3NlYXJjaC92NS9Db25zdGFudHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [.../core/profile/analyze/ProfileAnalyzeCollector.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplQ29sbGVjdG9yLmphdmE=) | `100% <100%> (ø)` | :arrow_up: |
   | [...ng/span/ConstructorWithSpanBuilderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1vcGVudHJhY2luZy1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vb3BlbnRyYWNpbmcvc3Bhbi9Db25zdHJ1Y3RvcldpdGhTcGFuQnVpbGRlckludGVyY2VwdG9yLmphdmE=) | `86.66% <100%> (ø)` | :arrow_up: |
   | [...y/socketio/NettySocketIOConnectionInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbmV0dHktc29ja2V0aW8tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbmV0dHkvc29ja2V0aW8vTmV0dHlTb2NrZXRJT0Nvbm5lY3Rpb25JbnRlcmNlcHRvci5qYXZh) | `76.92% <100%> (ø)` | :arrow_up: |
   | [...lking/apm/plugin/esjob/JobExecutorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZWxhc3RpYy1qb2ItMi54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL2Vzam9iL0pvYkV4ZWN1dG9ySW50ZXJjZXB0b3IuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
   | ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=footer). Last update [6aadb29...cfa12a8](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] ascrutae commented on issue #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

Posted by GitBox <gi...@apache.org>.
ascrutae commented on issue #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#issuecomment-582356745
 
 
   LGTM 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#issuecomment-582259358
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=h1) Report
   > Merging [#4320](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6aadb29c4fbff603828b35ff6091c4931bc27230?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4320/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4320   +/-   ##
   =======================================
     Coverage   27.12%   27.12%           
   =======================================
     Files        1175     1175           
     Lines       25616    25616           
     Branches     3646     3646           
   =======================================
     Hits         6948     6948           
     Misses      18061    18061           
     Partials      607      607
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=footer). Last update [6aadb29...cfa12a8](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#issuecomment-582259358
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=h1) Report
   > Merging [#4320](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6aadb29c4fbff603828b35ff6091c4931bc27230?src=pr&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `78.82%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4320/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4320      +/-   ##
   ==========================================
   + Coverage   27.12%   27.15%   +0.03%     
   ==========================================
     Files        1175     1175              
     Lines       25616    25621       +5     
     Branches     3646     3647       +1     
   ==========================================
   + Hits         6948     6958      +10     
   + Misses      18061    18058       -3     
   + Partials      607      605       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | :arrow_up: |
   | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...vation/opentracing/span/SpanSetTagInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1vcGVudHJhY2luZy1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vb3BlbnRyYWNpbmcvc3Bhbi9TcGFuU2V0VGFnSW50ZXJjZXB0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [.../customize/interceptor/BaseInterceptorMethods.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9jdXN0b21pemUtZW5oYW5jZS1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jdXN0b21pemUvaW50ZXJjZXB0b3IvQmFzZUludGVyY2VwdG9yTWV0aG9kcy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...walking/apm/plugin/elasticsearch/v5/Constants.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZWxhc3RpY3NlYXJjaC01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZWxhc3RpY3NlYXJjaC92NS9Db25zdGFudHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [.../core/profile/analyze/ProfileAnalyzeCollector.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplQ29sbGVjdG9yLmphdmE=) | `100% <100%> (ø)` | :arrow_up: |
   | [...ng/span/ConstructorWithSpanBuilderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1vcGVudHJhY2luZy1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vb3BlbnRyYWNpbmcvc3Bhbi9Db25zdHJ1Y3RvcldpdGhTcGFuQnVpbGRlckludGVyY2VwdG9yLmphdmE=) | `86.66% <100%> (ø)` | :arrow_up: |
   | [...gin/jdbc/connectionurl/parser/OracleURLParser.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vamRiYy1jb21tb25zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vamRiYy9jb25uZWN0aW9udXJsL3BhcnNlci9PcmFjbGVVUkxQYXJzZXIuamF2YQ==) | `98.21% <100%> (+2.13%)` | :arrow_up: |
   | [...y/socketio/NettySocketIOConnectionInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbmV0dHktc29ja2V0aW8tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbmV0dHkvc29ja2V0aW8vTmV0dHlTb2NrZXRJT0Nvbm5lY3Rpb25JbnRlcmNlcHRvci5qYXZh) | `76.92% <100%> (ø)` | :arrow_up: |
   | ... and [23 more](https://codecov.io/gh/apache/skywalking/pull/4320/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=footer). Last update [6aadb29...06a90e4](https://codecov.io/gh/apache/skywalking/pull/4320?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#discussion_r375071553
 
 

 ##########
 File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/OracleURLParser.java
 ##########
 @@ -94,6 +94,10 @@ private ConnectionInfo commonsURLParse() {
         String[] hostSegment = splitDatabaseAddress(host);
         String databaseName = fetchDatabaseNameFromURL();
         if (hostSegment.length == 1) {
+            if (databaseName.contains("/") && databaseName.split("/").length == 2) {
+                String[] portAndDatabaseName = databaseName.split("/");
+                return new ConnectionInfo(ComponentsDefine.OJDBC, DB_TYPE, host, Integer.valueOf(portAndDatabaseName[0]), portAndDatabaseName[1]);
+            }
 
 Review comment:
   Where is the `else`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services