[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request #1009: MINIFICPP-1497: Remove misleading ThreadPoolAdjust integration test

[GitBox <gi...@apache.org>]

martinzink opened a new pull request #1009:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1009


   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1009: MINIFICPP-1497: Remove misleading ThreadPoolAdjust integration test

[GitBox <gi...@apache.org>]

martinzink commented on a change in pull request #1009:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1009#discussion_r578654097



##########
File path: extensions/http-curl/tests/CMakeLists.txt
##########
@@ -95,7 +95,6 @@ add_test(NAME HTTPSiteToSiteTests COMMAND HTTPSiteToSiteTests "${TEST_RESOURCES}
 add_test(NAME TimeoutHTTPSiteToSiteTests COMMAND TimeoutHTTPSiteToSiteTests "${TEST_RESOURCES}/TestTimeoutHTTPSiteToSite.yml" "${TEST_RESOURCES}/" "http://localhost:8098/nifi-api")
 add_test(NAME SiteToSiteRestTest COMMAND SiteToSiteRestTest "${TEST_RESOURCES}/TestSite2SiteRest.yml" "${TEST_RESOURCES}/" "http://localhost:8077/nifi-api/site-to-site")
 add_test(NAME ControllerServiceIntegrationTests COMMAND ControllerServiceIntegrationTests "${TEST_RESOURCES}/TestControllerServices.yml" "${TEST_RESOURCES}/")
-add_test(NAME ThreadPoolAdjust COMMAND ThreadPoolAdjust "${TEST_RESOURCES}/ThreadPoolAdjust.yml" "${TEST_RESOURCES}/")

Review comment:
       Based on the name ThreadPoolAdjust, it is implied it tests the adjustments to the thread-pool or something along those lines, however extensions/http-curl/tests/ThreadPoolAdjust.cpp is just a copy of extensions/http-curl/tests/HttpPostIntegrationTest.cpp (only difference is that in the configuration nifi.flow.engine.threads is set to 1 instead of 8).
   The configuration yml (libminifi/test/resources/ThreadPoolAdjust.yml) is also almost the same as to what the HttpPostIntegrationTest uses (libminifi/test/resources/TestHTTPPost.yml)
   The test itself only runs assertion whether the InvokeHTTP processor is successfully started, nothing related to the threadpool.
   
   Having this test is currently misleading, we could just rename it but since it doesn't give anymore coverage than the aforementioned HttpPostIntegrationTest, I think we should just remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1009: MINIFICPP-1497: Remove misleading ThreadPoolAdjust integration test

[GitBox <gi...@apache.org>]

adamdebreceni closed pull request #1009:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1009


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org