You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "blcksrx (via GitHub)" <gi...@apache.org> on 2023/03/08 13:58:40 UTC

[GitHub] [airflow] blcksrx opened a new pull request, #29977: enhance spark_k8s_operator

blcksrx opened a new pull request, #29977:
URL: https://github.com/apache/airflow/pull/29977

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   Enhancement on `SparkKubernetesOperator`:
   
   - log the spark driver output to the airflow
   - provide `on_kill` method 
   - re-write `SparkKubernetesOperator` tests in `pytest`
   - generalise  and simplify `create_custom_object` and `get_custom_object` on `KubernetesHook`:
      - they are not only about `SparkApplication`
      - (In my opinion) deleting previous object is out of scope this method and airflow
      
   
   closes: #21325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29977: Enhance `SparkKubernetesOperator`

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29977:
URL: https://github.com/apache/airflow/pull/29977#issuecomment-1468931338

   Looks cool.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #29977: Enhance `SparkKubernetesOperator`

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29977:
URL: https://github.com/apache/airflow/pull/29977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org