You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jfrag1 (via GitHub)" <gi...@apache.org> on 2023/06/16 19:21:36 UTC
[GitHub] [superset] jfrag1 opened a new pull request, #24434: fix: Revert to old endpoint temporarily to enable sharing saved queries
jfrag1 opened a new pull request, #24434:
URL: https://github.com/apache/superset/pull/24434
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24434: fix: Revert to old endpoint temporarily to enable sharing saved queries
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24434:
URL: https://github.com/apache/superset/pull/24434#issuecomment-1595272757
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24434](https://app.codecov.io/gh/apache/superset/pull/24434?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d9fae3d) into [master](https://app.codecov.io/gh/apache/superset/commit/01689b4c9483f40bd0a3fdf98fa2331d31cbeba1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (01689b4) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d9fae3d differs from pull request most recent head d90f6f8. Consider uploading reports for the commit d90f6f8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24434 +/- ##
==========================================
- Coverage 68.93% 68.93% -0.01%
==========================================
Files 1904 1904
Lines 73879 73879
Branches 8119 8119
==========================================
- Hits 50928 50927 -1
- Misses 20840 20841 +1
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.65% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `69.16% <ø> (-0.27%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a diff in pull request #24434: fix: Revert to old endpoint temporarily to enable sharing saved queries
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #24434:
URL: https://github.com/apache/superset/pull/24434#discussion_r1235552918
##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -1372,12 +1372,11 @@ export function popStoredQuery(urlId) {
export function popSavedQuery(saveQueryId) {
return function (dispatch) {
return SupersetClient.get({
- endpoint: `/api/v1/saved_query/${saveQueryId}`,
+ endpoint: `/savedqueryviewapi/api/get/${saveQueryId}`,
Review Comment:
@jfrag1 thanks for the change. Is there any reason you opted for this approach as opposed to keeping the new endpoint and relaxing the `SavedQueryFilter` filter criterion? I guess the merit with the later is it's clearer how this works as opposed to the somewhat magical (and obscure) FAB REST API endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #24434: fix: Revert to old endpoint temporarily to enable sharing saved queries
Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh merged PR #24434:
URL: https://github.com/apache/superset/pull/24434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jfrag1 commented on a diff in pull request #24434: fix: Revert to old endpoint temporarily to enable sharing saved queries
Posted by "jfrag1 (via GitHub)" <gi...@apache.org>.
jfrag1 commented on code in PR #24434:
URL: https://github.com/apache/superset/pull/24434#discussion_r1235575992
##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -1372,12 +1372,11 @@ export function popStoredQuery(urlId) {
export function popSavedQuery(saveQueryId) {
return function (dispatch) {
return SupersetClient.get({
- endpoint: `/api/v1/saved_query/${saveQueryId}`,
+ endpoint: `/savedqueryviewapi/api/get/${saveQueryId}`,
Review Comment:
@john-bodley The main reason I did it this way is that I'm pretty sure there are sevaral FAB-generated endpoints under the `SavedQueryRestApi` that utilize the `SavedQueryFilter` (set as the `base_filter` on the class), and I didn't want to change the behavior for those. For example, the endpoint that fetches a list of a user's saved queries could start returning a list of all saved queries with that change.
##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -1372,12 +1372,11 @@ export function popStoredQuery(urlId) {
export function popSavedQuery(saveQueryId) {
return function (dispatch) {
return SupersetClient.get({
- endpoint: `/api/v1/saved_query/${saveQueryId}`,
+ endpoint: `/savedqueryviewapi/api/get/${saveQueryId}`,
Review Comment:
@john-bodley The main reason I did it this way is that I'm pretty sure there are several FAB-generated endpoints under the `SavedQueryRestApi` that utilize the `SavedQueryFilter` (set as the `base_filter` on the class), and I didn't want to change the behavior for those. For example, the endpoint that fetches a list of a user's saved queries could start returning a list of all saved queries with that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org