You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ariel Weisberg (JIRA)" <ji...@apache.org> on 2015/08/11 23:57:46 UTC
[jira] [Commented] (CASSANDRA-9749) CommitLogReplayer continues
startup after encountering errors
[ https://issues.apache.org/jira/browse/CASSANDRA-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692326#comment-14692326 ]
Ariel Weisberg commented on CASSANDRA-9749:
-------------------------------------------
Boolean.getBoolean() can check the system property
https://github.com/blambov/cassandra/commit/6311fe1c4e66a73f9035a6463686a5d87cf7577c#diff-348a1347dacf897385fb0a97116a1b5eR615
What is the motivation for changing this to warn? Is it going to cause operators concern that is unwarranted?
https://github.com/blambov/cassandra/commit/6311fe1c4e66a73f9035a6463686a5d87cf7577c#diff-348a1347dacf897385fb0a97116a1b5eR154
Do you have to make all those object arrays for handleReplayError? varargs won't handle it correctly?
The changes look reasonable. Some of the error conditions that now are supposed to throw don't have unit test coverage. They weren't tested before either, but this an opportunity to make sure the errors work.
> CommitLogReplayer continues startup after encountering errors
> -------------------------------------------------------------
>
> Key: CASSANDRA-9749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9749
> Project: Cassandra
> Issue Type: Bug
> Reporter: Blake Eggleston
> Assignee: Branimir Lambov
> Fix For: 2.2.x
>
>
> There are a few places where the commit log recovery method either skips sections or just returns when it encounters errors.
> Specifically if it can't read the header here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L298
> Or if there are compressor problems here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L314 and here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L366
> Whether these are user-fixable or not, I think we should require more direct user intervention (ie: fix what's wrong, or remove the bad file and restart) since we're basically losing data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)