globodns few issues reported with coverity

[Santhosh Edukulla <sa...@citrix.com>]

All,

There were few issues reported under new code addition of globodns,apart from others. For globodns, daniel, you may want to look in to them. Please check.

** CID 1232329:  Explicit null dereferenced  (FORWARD_NULL)
/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java: 761 in org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$3.doInTransactionWithoutResult(com.cloud.utils.db.TransactionStatus)()

** CID 1232328:  Dereference after null check  (FORWARD_NULL)
/utils/src/com/cloud/utils/net/NetUtils.java: 1324 in com.cloud.utils.net.NetUtils.countIp6InRange(java.lang.String)()

** CID 1232332:  Dereference null return value  (NULL_RETURNS)
/plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/resource/GloboDnsResource.java: 295 in com.globo.globodns.cloudstack.resource.GloboDnsResource.createOrUpdateReverse(java.lang.String, java.lang.String, java.lang.Long, boolean)()

** CID 1232331:  Dereference null return value  (NULL_RETURNS)
/plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/resource/GloboDnsResource.java: 253 in com.globo.globodns.cloudstack.resource.GloboDnsResource.execute(com.globo.globodns.cloudstack.commands.CreateOrUpdateRecordAndReverseCommand)()

** CID 1232330:  Dereference null return value  (NULL_RETURNS)
/plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/resource/GloboDnsResource.java: 342 in com.globo.globodns.cloudstack.resource.GloboDnsResource.removeRecord(java.lang.String, java.lang.String, java.lang.String, boolean, boolean)()

** CID 1232337:  Cross-site scripting  (XSS)
/awsapi/src/com/cloud/bridge/service/S3RestServlet.java: 451 in com.cloud.bridge.service.controller.s3.S3BucketAction.executeGetBucket(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)()

** CID 1232336:  Cross-site scripting  (XSS)
/awsapi/src/com/cloud/bridge/service/S3RestServlet.java: 451 in com.cloud.bridge.service.controller.s3.S3BucketAction.executeListMultipartUploads(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)()

** CID 1232335:  Cross-site scripting  (XSS)
/awsapi/src/com/cloud/bridge/service/S3RestServlet.java: 451 in com.cloud.bridge.service.controller.s3.S3BucketAction.executeGetBucketObjectVersions(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)()
/awsapi/src/com/cloud/bridge/service/S3RestServlet.java: 451 in com.cloud.bridge.service.controller.s3.S3BucketAction.executeGetBucketObjectVersions(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)()

** CID 1232334:  Cross-site scripting  (XSS)
/awsapi/src/com/cloud/bridge/service/S3RestServlet.java: 451 in com.cloud.bridge.service.controller.s3.S3BucketAction.executeListMultipartUploads(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)()

** CID 1232333:  Cross-site scripting  (XSS)
/awsapi/src/com/cloud/bridge/service/S3RestServlet.java: 451 in com.cloud.bridge.service.controller.s3.S3BucketAction.executeListMultipartUploads(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)()

** CID 1232343:  USELESS_STRING: Useless/non-informative string generated  (FB.DMI_INVOKING_TOSTRING_ON_ARRAY)
/plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java: 550 in com.cloud.hypervisor.hyperv.resource.HypervDirectConnectResource.execute(org.apache.cloudstack.storage.command.CopyCommand)()

** CID 1232342:  DLS: Dead local store  (FB.DLS_DEAD_LOCAL_STORE)
/plugins/network-elements/globodns/src/com/globo/globodns/cloudstack/resource/GloboDnsResource.java: 365 in com.globo.globodns.cloudstack.resource.GloboDnsResource.createOrUpdateRecord(java.lang.Long, java.lang.String, java.lang.String, java.lang.String, boolean)()

Santhosh