You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "coheigea (via GitHub)" <gi...@apache.org> on 2026/04/23 09:47:47 UTC
[PR] Add a boolean to guard against remove schema download for WS-MEX [cxf]
coheigea opened a new pull request, #3054:
URL: https://github.com/apache/cxf/pull/3054
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a boolean to guard against remove schema download for WS-MEX [cxf]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #3054:
URL: https://github.com/apache/cxf/pull/3054#discussion_r3130056484
##########
rt/ws/security/src/main/java/org/apache/cxf/ws/security/trust/AbstractSTSClient.java:
##########
@@ -614,7 +620,22 @@
}
}
- private Element downloadSchema(String schemaLocation) throws Exception {
+ protected Element getSchemaElement(MetadataSection s) throws Exception {
+ Element schemaElement = (Element)s.getAny();
+ if (schemaElement == null) {
+ if (!allowMexMetadataSchemaLocation) {
+ LOG.info("Loading a schema from WS-MEX MetadataSection Location is disabled by "
+ + " default. Enable allowMexMetadataSchemaLocation to allow it.");
+ } else {
+ String schemaLocation = s.getLocation();
+ LOG.info("XSD schema location: " + schemaLocation);
Review Comment:
## CodeQL / Insertion of sensitive information into log files
This [potentially sensitive information](1) is written to a log file.
[Show more details](https://github.com/apache/cxf/security/code-scanning/2214)
##########
rt/ws/security/src/main/java/org/apache/cxf/ws/security/trust/AbstractSTSClient.java:
##########
@@ -614,7 +620,22 @@
}
}
- private Element downloadSchema(String schemaLocation) throws Exception {
+ protected Element getSchemaElement(MetadataSection s) throws Exception {
+ Element schemaElement = (Element)s.getAny();
+ if (schemaElement == null) {
+ if (!allowMexMetadataSchemaLocation) {
+ LOG.info("Loading a schema from WS-MEX MetadataSection Location is disabled by "
+ + " default. Enable allowMexMetadataSchemaLocation to allow it.");
+ } else {
+ String schemaLocation = s.getLocation();
+ LOG.info("XSD schema location: " + schemaLocation);
Review Comment:
## CodeQL / Log Injection
This log entry depends on a [user-provided value](1).
This log entry depends on a [user-provided value](2).
This log entry depends on a [user-provided value](3).
[Show more details](https://github.com/apache/cxf/security/code-scanning/2215)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a boolean to guard against remove schema download for WS-MEX [cxf]
Posted by "coheigea (via GitHub)" <gi...@apache.org>.
coheigea merged PR #3054:
URL: https://github.com/apache/cxf/pull/3054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org