You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/27 13:39:20 UTC

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

hartmannathan commented on code in PR #6512:
URL: https://github.com/apache/incubator-nuttx/pull/6512#discussion_r907397184


##########
drivers/syslog/Kconfig:
##########
@@ -373,4 +373,13 @@ config SYSLOG_CHARDEV
 		byte output with no time-stamping or any other SYSLOG features
 		supported.
 
+config SYSLOG_SCHEDLOCK
+	bool "SYSLOG schedlock (DANGER: may degrade NuttX Realtime Performance)"

Review Comment:
   s/schedlock/sched_lock/ to make this greppable?



##########
drivers/syslog/Kconfig:
##########
@@ -373,4 +373,13 @@ config SYSLOG_CHARDEV
 		byte output with no time-stamping or any other SYSLOG features
 		supported.
 
+config SYSLOG_SCHEDLOCK
+	bool "SYSLOG schedlock (DANGER: may degrade NuttX Realtime Performance)"
+	default n
+	---help---
+		Use schedlock to make sure syslogs from multiple threads are not garbled.

Review Comment:
   s/schedlock/sched_lock/ here as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org