You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/16 07:35:16 UTC
[GitHub] wujimin commented on a change in pull request #627: [SCB-292]
chassis support standard parameter validation
wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r188527793
##########
File path: demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
##########
@@ -147,4 +169,85 @@ private static void testRawJsonParam(RestTemplate template, String cseUrlPrefix)
TestMgr.check("hello Tom",
template.postForObject(cseUrlPrefix + "/compute/testrawjson", jsonPerson, String.class));
}
+
+ private static void testValidatorAddFail(RestTemplate template, String cseUrlPrefix) {
+ Map<String, String> params = new HashMap<>();
+ params.put("a", "5");
+ params.put("b", "3");
+ boolean isExcep = false;
+ try {
+ template.postForObject(cseUrlPrefix + "add", params, Integer.class);
+ } catch (InvocationException e) {
+ isExcep = true;
+ TestMgr.check(400, e.getStatus().getStatusCode());
+ TestMgr.check(Status.BAD_REQUEST, e.getReasonPhrase());
+ TestMgr.check(
+ "CommonExceptionData [message=[ConstraintViolationImpl{interpolatedMessage='must be greater than or equal to 20', propertyPath=add.arg1, rootBeanClass=class org.apache.servicecomb.demo.jaxrs.server.Validator, messageTemplate='{javax.validation.constraints.Min.message}'}]]",
Review comment:
it's not about test case......
root cause is that developer use exception.toString to be response information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services