You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2012/08/15 13:38:59 UTC
svn commit: r1373346 - in /lucene/dev/branches/branch_4x: ./ lucene/
lucene/core/
lucene/core/src/test/org/apache/lucene/store/TestMockDirectoryWrapper.java
lucene/core/src/test/org/apache/lucene/util/junitcompat/TestFailIfDirectoryNotClosed.java
Author: rmuir
Date: Wed Aug 15 11:38:59 2012
New Revision: 1373346
URL: http://svn.apache.org/viewvc?rev=1373346&view=rev
Log:
test this cleaner, we don't need a nested test, just want to ensure MDW throws exception on close
Added:
lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/store/TestMockDirectoryWrapper.java
- copied unchanged from r1373343, lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/store/TestMockDirectoryWrapper.java
Modified:
lucene/dev/branches/branch_4x/ (props changed)
lucene/dev/branches/branch_4x/lucene/ (props changed)
lucene/dev/branches/branch_4x/lucene/core/ (props changed)
lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/util/junitcompat/TestFailIfDirectoryNotClosed.java
Modified: lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/util/junitcompat/TestFailIfDirectoryNotClosed.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/util/junitcompat/TestFailIfDirectoryNotClosed.java?rev=1373346&r1=1373345&r2=1373346&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/util/junitcompat/TestFailIfDirectoryNotClosed.java (original)
+++ lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/util/junitcompat/TestFailIfDirectoryNotClosed.java Wed Aug 15 11:38:59 2012
@@ -17,13 +17,7 @@ package org.apache.lucene.util.junitcomp
* limitations under the License.
*/
-import java.io.IOException;
-
-import org.apache.lucene.index.IndexWriter;
-import org.apache.lucene.index.IndexWriterConfig;
import org.apache.lucene.store.Directory;
-import org.apache.lucene.store.MockDirectoryWrapper;
-import org.apache.lucene.store.SingleInstanceLockFactory;
import org.junit.Assert;
import org.junit.Test;
import org.junit.runner.JUnitCore;
@@ -40,39 +34,10 @@ public class TestFailIfDirectoryNotClose
System.out.println(dir.toString());
}
}
-
- public static class Nested2 extends WithNestedTests.AbstractNestedTest {
- public void testDummy() throws IOException {
- MockDirectoryWrapper dir = newMockDirectory();
- IndexWriter iw = new IndexWriter(dir, new IndexWriterConfig(TEST_VERSION_CURRENT, null));
- dir.close();
- }
- }
-
- public static class Nested3 extends WithNestedTests.AbstractNestedTest {
- public void testDummy() throws IOException {
- MockDirectoryWrapper dir = newMockDirectory();
- dir.setLockFactory(new SingleInstanceLockFactory());
- IndexWriter iw = new IndexWriter(dir, new IndexWriterConfig(TEST_VERSION_CURRENT, null));
- dir.close();
- }
- }
@Test
public void testFailIfDirectoryNotClosed() {
Result r = JUnitCore.runClasses(Nested1.class);
Assert.assertEquals(1, r.getFailureCount());
}
-
- @Test
- public void testFailIfIndexWriterNotClosed() {
- Result r = JUnitCore.runClasses(Nested2.class);
- Assert.assertEquals(1, r.getFailureCount());
- }
-
- @Test
- public void testFailIfIndexWriterNotClosedChangeLockFactory() {
- Result r = JUnitCore.runClasses(Nested3.class);
- Assert.assertEquals(1, r.getFailureCount());
- }
}