You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/14 01:14:46 UTC

[GitHub] [tvm] masahi edited a comment on pull request #7833: [Vulkan] Support uniform buffer object for passing many scalar arguments (Take 2)

masahi edited a comment on pull request #7833:
URL: https://github.com/apache/tvm/pull/7833#issuecomment-819149449


   @tqchen I believe I've addressed all of your comments. 
   
   Also on https://github.com/apache/tvm/pull/7833#discussion_r612758714, between two `memcpy` from different pipelines, there is always a pipeline barrier https://github.com/apache/tvm/blob/9df431ff4480fac3edd9422bdb4af2c34a12f5f8/src/runtime/vulkan/vulkan.cc#L1240, even in a deferred mode. So I think there should be no concern, does that sound about right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org