[jira] [Commented] (BOOKKEEPER-256) Update remote component sequence IDs only for messages from the source region

["Hyun Goo Kang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273736#comment-13273736 ] 

Hyun Goo Kang commented on BOOKKEEPER-256:
------------------------------------------

Couple comments:
- In takeRegionSpecificMaximum(), it looks like we would take a component from id2 regardless of its region, if its corresponding component does not exist in id1. Is that what you want?

- This is out of scope, but I guess we could update the message's seq-id after you merge the two seq-ids in LocalDBPersistenceManager::persistMessage.

- This is out of scope again, but it looks like the new message builder that merges two ids is never used (RegionManager::doRemoteSubscribe, line 214).

- It looks like your one-line fix in RegionManager.java would be sufficient for this issue. The existing 'takeRegionMaximum' should work just fine with the new sequence-ids that contains only the srcRegion component. Could you also add some comment to the line you changed in RegionManager.java to clarify why we would want to propagate only the srcRegion component?

- Is 'takeRegionMaximum' doesn't seem to be used anywhere else. We could remove it if we decide to keep the 'takeRegionSpecificMaximum' method.
                
> Update remote component sequence IDs only for messages from the source region
> -----------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-256
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-256
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: hedwig-server
>    Affects Versions: 4.1.0
>            Reporter: Aniruddha
>            Assignee: Aniruddha
>            Priority: Minor
>             Fix For: 4.1.0
>
>         Attachments: BK-256.patch
>
>
> In the current setup, remote components for a message being persisted don't give any meaningful information about the number of messages the hub has received for that topic from other regions. The provided patch fixes this by updating the remote component of the locally persisted message for a region X only if the message received by the RegionManager originates from region X. 
> Edit - You can take a look at the discussion at http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201205.mbox/%3cCAOLhyDTEm5=p8eMD8XmVCY_6ktB40RQx6dWWY50ARbAEbdgtsQ@mail.gmail.com%3e for context.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira