You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/30 10:41:20 UTC

[GitHub] [netbeans] neilcsmith-net commented on pull request #3136: [NETBEANS-5914] Call notifyAll + avoid delivering changes under a lock

neilcsmith-net commented on pull request #3136:
URL: https://github.com/apache/netbeans/pull/3136#issuecomment-908237054


   Doesn't this need the same change to take the notifications outside of the lock in `LazyLookupProviders`?  Looking at the stack traces provided with NETBEANS-5914, all the threads with the `DelegatingLookupImpl` lock are stuck in `collectFires()` - that won't change with this will it?  It's before the async notification - https://github.com/apache/netbeans/blob/master/platform/openide.util.lookup/src/org/openide/util/lookup/ProxyLookup.java#L228  They are all in a listener call from a `LazyLookupProvider` under lock though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists