You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/12 03:15:00 UTC
Review Request 13485: Fixed slave to use linkedhashmap to store tasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13485/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-497
https://issues.apache.org/jira/browse/MESOS-497
Repository: mesos-git
Description
-------
This will ensure that queued tasks are launched in the same order as they are received!
Diffs
-----
src/slave/http.cpp c45dfb457971626565185f103538f1ec893abc40
src/slave/slave.hpp 8ba605bafae36e0418969ba9cea51dd0cd7e91db
src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
Diff: https://reviews.apache.org/r/13485/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13485: Fixed slave to use LinkedHashMap to store tasks.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 14, 2013, 12:21 a.m., Ben Mahler wrote:
> > Can you add TODOs on each of the .values() calls to use foreachvalue when LinkeHashMap supports it? I want to make sure we keep track of these unnecessary copies and revert them once we can.
done
> On Aug. 14, 2013, 12:21 a.m., Ben Mahler wrote:
> > src/slave/http.cpp, lines 218-223
> > <https://reviews.apache.org/r/13485/diff/2/?file=340075#file340075line218>
> >
> > Do end users need to know the semantic difference between terminated tasks and completed tasks?
> >
> > 1. If so, please update the webui to show them (probably as completed_tasks rather than a separate table for terminated_tasks).
> >
> > 2. If not, please combine them into completed_tasks.
> >
> > IMO #2 is simpler. Ship it for #2 :)
#2 sgtm. fixed.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13485/#review25103
-----------------------------------------------------------
On Aug. 12, 2013, 5:49 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13485/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 5:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-497
> https://issues.apache.org/jira/browse/MESOS-497
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will ensure that queued tasks are launched in the same order as they are received!
>
>
> Diffs
> -----
>
> src/slave/http.cpp c45dfb457971626565185f103538f1ec893abc40
> src/slave/slave.hpp 8ba605bafae36e0418969ba9cea51dd0cd7e91db
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
>
> Diff: https://reviews.apache.org/r/13485/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13485: Fixed slave to use LinkedHashMap to store tasks.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13485/#review25103
-----------------------------------------------------------
Ship it!
Can you add TODOs on each of the .values() calls to use foreachvalue when LinkeHashMap supports it? I want to make sure we keep track of these unnecessary copies and revert them once we can.
src/slave/http.cpp
<https://reviews.apache.org/r/13485/#comment49321>
Do end users need to know the semantic difference between terminated tasks and completed tasks?
1. If so, please update the webui to show them (probably as completed_tasks rather than a separate table for terminated_tasks).
2. If not, please combine them into completed_tasks.
IMO #2 is simpler. Ship it for #2 :)
- Ben Mahler
On Aug. 12, 2013, 5:49 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13485/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 5:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-497
> https://issues.apache.org/jira/browse/MESOS-497
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will ensure that queued tasks are launched in the same order as they are received!
>
>
> Diffs
> -----
>
> src/slave/http.cpp c45dfb457971626565185f103538f1ec893abc40
> src/slave/slave.hpp 8ba605bafae36e0418969ba9cea51dd0cd7e91db
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
>
> Diff: https://reviews.apache.org/r/13485/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13485: Fixed slave to use LinkedHashMap to store tasks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13485/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 6:03 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. nnfr.
Bugs: MESOS-497
https://issues.apache.org/jira/browse/MESOS-497
Repository: mesos-git
Description
-------
This will ensure that queued tasks are launched in the same order as they are received!
Diffs (updated)
-----
src/slave/http.cpp c45dfb457971626565185f103538f1ec893abc40
src/slave/slave.hpp 464d2249a28095fa5a8f66acc270bea70cc01749
src/slave/slave.cpp dbc4473d37d6581f488ec39b7b7dcb5936935e6f
Diff: https://reviews.apache.org/r/13485/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13485: Fixed slave to use LinkedHashMap to store tasks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13485/
-----------------------------------------------------------
(Updated Aug. 12, 2013, 5:49 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
s/linkedhashmap/LinkedHashMap/
Summary (updated)
-----------------
Fixed slave to use LinkedHashMap to store tasks.
Bugs: MESOS-497
https://issues.apache.org/jira/browse/MESOS-497
Repository: mesos-git
Description
-------
This will ensure that queued tasks are launched in the same order as they are received!
Diffs (updated)
-----
src/slave/http.cpp c45dfb457971626565185f103538f1ec893abc40
src/slave/slave.hpp 8ba605bafae36e0418969ba9cea51dd0cd7e91db
src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
Diff: https://reviews.apache.org/r/13485/diff/
Testing
-------
make check
Thanks,
Vinod Kone