You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/07/03 23:52:45 UTC
Re: Review Request 12256: Added a "registered" key/value pair to slave's
stats.json.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12256/
-----------------------------------------------------------
(Updated July 3, 2013, 9:52 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
updated the summary. NNFR.
Summary (updated)
-----------------
Added a "registered" key/value pair to slave's stats.json.
Repository: mesos
Description
-------
This helps us get alerted when a slave is partitioned or otherwise unable to connect to the master.
Diffs (updated)
-----
src/slave/http.cpp dc2955f80ad7bfeea1b865e8d1b49da0beaa07eb
Diff: https://reviews.apache.org/r/12256/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 12256: Added a "registered" key/value pair to slave's
stats.json.
Posted by Vinod Kone <vi...@gmail.com>.
> On July 9, 2013, 1:17 a.m., Benjamin Hindman wrote:
> > src/slave/http.cpp, line 285
> > <https://reviews.apache.org/r/12256/diff/3/?file=318088#file318088line285>
> >
> > Can you do:
> >
> > object.values["registered"] = slave.master ? "1" : "0";
duh, thanks.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12256/#review22874
-----------------------------------------------------------
On July 3, 2013, 9:52 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12256/
> -----------------------------------------------------------
>
> (Updated July 3, 2013, 9:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This helps us get alerted when a slave is partitioned or otherwise unable to connect to the master.
>
>
> Diffs
> -----
>
> src/slave/http.cpp dc2955f80ad7bfeea1b865e8d1b49da0beaa07eb
>
> Diff: https://reviews.apache.org/r/12256/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 12256: Added a "registered" key/value pair to slave's
stats.json.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12256/#review22874
-----------------------------------------------------------
Ship it!
src/slave/http.cpp
<https://reviews.apache.org/r/12256/#comment46618>
Can you do:
object.values["registered"] = slave.master ? "1" : "0";
- Benjamin Hindman
On July 3, 2013, 9:52 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12256/
> -----------------------------------------------------------
>
> (Updated July 3, 2013, 9:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This helps us get alerted when a slave is partitioned or otherwise unable to connect to the master.
>
>
> Diffs
> -----
>
> src/slave/http.cpp dc2955f80ad7bfeea1b865e8d1b49da0beaa07eb
>
> Diff: https://reviews.apache.org/r/12256/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 12256: Added a "registered" key/value pair to slave's
stats.json.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12256/
-----------------------------------------------------------
(Updated July 17, 2013, 6:40 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased and benh's. nnfr.
Repository: mesos
Description
-------
This helps us get alerted when a slave is partitioned or otherwise unable to connect to the master.
Diffs (updated)
-----
src/slave/http.cpp dc2955f80ad7bfeea1b865e8d1b49da0beaa07eb
Diff: https://reviews.apache.org/r/12256/diff/
Testing
-------
make check
Thanks,
Vinod Kone