You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2015/10/14 18:01:23 UTC
[GitHub] couchdb-couch-log pull request: Create a custom logging backend fo...
GitHub user nickva opened a pull request:
https://github.com/apache/couchdb-couch-log/pull/8
Create a custom logging backend for unit tests.
* Disables logging of anything below error level.
* Backend is enabled automatically if running in test mode.
* For couch_log's own tests, use mocking in order to bypass testing mode.
* For mocking to work with couch_log tests, move tests to
a separate tests/ folder.
COUCHDB-2855
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-log 2855-custom-test-logger-backend
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-log/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit cc808a45d1a021281ac057630e311fcb4d1d3ed5
Author: Nick Vatamaniuc <va...@gmail.com>
Date: 2015-10-14T15:53:54Z
Create a custom logging backend for unit tests.
* Disables logging of anything below error level.
* Backend is enabled automatically if running in test mode.
* For couch_log's own tests, use mocking in order to bypass testing mode.
* For mocking to work with couch_log tests, move tests to
a separate tests/ folder.
COUCHDB-2855
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Create a custom logging backend fo...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-log/pull/8#issuecomment-148102772
@nickva I think it worth to dig into this direction. Because, assume one of your test fails and you want to see the logs: you'll have to patch that code while all this problem is on configuration domain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Create a custom logging backend fo...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the pull request:
https://github.com/apache/couchdb-couch-log/pull/8#issuecomment-148101672
@kxepal I don't know why our current configuration of lager/eunit doesn't work. I suspect it has to do with using config script files, coupled with eunit resetting vm apps environments between app tests suits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Create a custom logging backend fo...
Posted by nickva <gi...@git.apache.org>.
Github user nickva closed the pull request at:
https://github.com/apache/couchdb-couch-log/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Create a custom logging backend fo...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb-couch-log/pull/8#issuecomment-148101209
Great work! Thanks @nickva!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Create a custom logging backend fo...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the pull request:
https://github.com/apache/couchdb-couch-log/pull/8#issuecomment-148112379
Fixed via config file in https://github.com/apache/couchdb/commit/c6b9e74370210bbd14c8535e8457d85a26ddd945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Create a custom logging backend fo...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-log/pull/8#issuecomment-148100855
Why it's not possible to configure current backend to do the same when eunit runs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---