You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/10 00:22:37 UTC
Review Request 41159: Corrected a comment in reservation endpoint
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41159/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Michael Park.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/reservation_endpoints_tests.cpp c3833d0949df42c9f8dadf3c6e6b0b49e6cbdce9
Diff: https://reviews.apache.org/r/41159/diff/
Testing
-------
None.
Thanks,
Alexander Rukletsov
Re: Review Request 41159: Corrected a comment in reservation endpoint
tests.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41159/#review109733
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Dec. 9, 2015, 11:22 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41159/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 11:22 p.m.)
>
>
> Review request for mesos, Greg Mann and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/reservation_endpoints_tests.cpp c3833d0949df42c9f8dadf3c6e6b0b49e6cbdce9
>
> Diff: https://reviews.apache.org/r/41159/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41159: Corrected a comment in reservation endpoint
tests.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41159/#review109636
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Dec. 9, 2015, 11:22 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41159/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 11:22 p.m.)
>
>
> Review request for mesos, Greg Mann and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/reservation_endpoints_tests.cpp c3833d0949df42c9f8dadf3c6e6b0b49e6cbdce9
>
> Diff: https://reviews.apache.org/r/41159/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41159: Corrected a comment in reservation endpoint
tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41159/#review109630
-----------------------------------------------------------
Ship it!
Good catch, thanks!!
- Greg Mann
On Dec. 9, 2015, 11:22 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41159/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 11:22 p.m.)
>
>
> Review request for mesos, Greg Mann and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/reservation_endpoints_tests.cpp c3833d0949df42c9f8dadf3c6e6b0b49e6cbdce9
>
> Diff: https://reviews.apache.org/r/41159/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41159: Corrected a comment in reservation endpoint
tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41159/#review109686
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41159]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 9, 2015, 11:22 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41159/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 11:22 p.m.)
>
>
> Review request for mesos, Greg Mann and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/reservation_endpoints_tests.cpp c3833d0949df42c9f8dadf3c6e6b0b49e6cbdce9
>
> Diff: https://reviews.apache.org/r/41159/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>