[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4891: TP: adds ability to perform a quick search, override default pagination size and clear column filters to servers table

[GitBox <gi...@apache.org>]

mitchell852 commented on a change in pull request #4891:
URL: https://github.com/apache/trafficcontrol/pull/4891#discussion_r458236040



##########
File path: traffic_portal/app/src/common/modules/table/servers/TableServersController.js
##########
@@ -548,6 +553,20 @@ var TableServersController = function(servers, $scope, $state, $uibModal, $windo
 		}
 	};
 
+	$scope.onQuickSearchChanged = function() {
+		$scope.gridOptions.api.setQuickFilter($scope.quickSearch);
+		localStorage.setItem("servers_quick_search", $scope.quickSearch);
+	};
+
+	$scope.onPageSizeChanged = function() {
+		const value = Number($scope.pageSize);

Review comment:
       maybe not but i recall it not working before the casting. casting a number to a number won't hurt so...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org