You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/03/30 12:33:18 UTC

[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #4604: [KYUUBI #1652] Support Flink yarn application mode

cxzl25 commented on code in PR #4604:
URL: https://github.com/apache/kyuubi/pull/4604#discussion_r1153188907


##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/result/ResultSet.scala:
##########
@@ -68,6 +69,21 @@ object ResultSet {
       .build
   }
 
+  def fromJobId(jobID: JobID): ResultSet = {
+    var data: Array[Row] = null;
+    if (jobID != null) {
+      data = Array(Row.of(jobID.toString));
+    } else {
+      // should not happen
+      data = Array(Row.of("(Empty Job ID)"));
+    }

Review Comment:
   ```suggestion
       val data: Array[Row] = if (jobID != null) {
         Array(Row.of(jobID.toString))
       } else {
         // should not happen
         Array(Row.of("(Empty Job ID)"))
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org