You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/30 17:23:21 UTC
[GitHub] [nifi] markap14 opened a new pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…
markap14 opened a new pull request #4244:
URL: https://github.com/apache/nifi/pull/4244
…ters before writing flow.xml.gz
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…
Posted by GitBox <gi...@apache.org>.
mcgilman commented on pull request #4244:
URL: https://github.com/apache/nifi/pull/4244#issuecomment-623640690
Thanks for the PR @markap14! Thanks for the review @ottobackwards! This has been merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4244:
URL: https://github.com/apache/nifi/pull/4244#issuecomment-623538477
Sure, updated unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4244:
URL: https://github.com/apache/nifi/pull/4244#issuecomment-622066867
This looks right, though I'm not familiar with the code. Is there a way to write a test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4244:
URL: https://github.com/apache/nifi/pull/4244#issuecomment-623598263
+1 fwiw pending ci-workflow completion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4244:
URL: https://github.com/apache/nifi/pull/4244#issuecomment-623595257
Yeah, the Strings in the unit tests were definitely wrong. But for some reason the tests were passing in my IntelliJ. But after I did a full re-build, they started failing, as they should. Fixed now and pushed the update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4244:
URL: https://github.com/apache/nifi/pull/4244#issuecomment-623599036
is worth plenty - thanks for sticking with him on this otto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4244:
URL: https://github.com/apache/nifi/pull/4244#issuecomment-623572437
Great, the tests look like they are failing though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org