You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/31 08:16:32 UTC
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8371: Change sec2tick macros to round up
xiaoxiang781216 commented on code in PR #8371:
URL: https://github.com/apache/nuttx/pull/8371#discussion_r1091580504
##########
include/nuttx/clock.h:
##########
@@ -145,41 +145,49 @@
* preferred for that reason (at the risk of overflow)
*/
-#define TICK_PER_HOUR (USEC_PER_HOUR / USEC_PER_TICK) /* Truncates! */
-#define TICK_PER_MIN (USEC_PER_MIN / USEC_PER_TICK) /* Truncates! */
-#define TICK_PER_SEC (USEC_PER_SEC / USEC_PER_TICK) /* Truncates! */
-#define TICK_PER_MSEC (USEC_PER_MSEC / USEC_PER_TICK) /* Truncates! */
-#define TICK_PER_DSEC (USEC_PER_DSEC / USEC_PER_TICK) /* Truncates! */
-#define TICK_PER_HSEC (USEC_PER_HSEC / USEC_PER_TICK) /* Truncates! */
+/* TICK_PER_* truncates! */
-#define MSEC_PER_TICK (USEC_PER_TICK / USEC_PER_MSEC) /* Truncates! */
-#define NSEC_PER_TICK (USEC_PER_TICK * NSEC_PER_USEC) /* Exact */
+#define TICK_PER_HOUR (USEC_PER_HOUR / USEC_PER_TICK)
Review Comment:
should we use the roundup for these constant too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org