You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/25 16:07:28 UTC

[GitHub] [incubator-superset] etr2460 opened a new pull request #11063: fix: sql lab autocomplete width

etr2460 opened a new pull request #11063:
URL: https://github.com/apache/incubator-superset/pull/11063


   ### SUMMARY
   Unfortunately, the previous fix doesn't work in production environments because Ace Editor applies a bunch of new CSS when the autocomplete is open, thus overriding the selector in SQL Lab. Because this doesn't repro in dev, and I don't think such a small change is worth a huge amount of investigation, I've added `!important` and a comment.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   See the correct class being applied: 
   <img width="233" alt="Screen Shot 2020-09-25 at 9 03 18 AM" src="https://user-images.githubusercontent.com/7409244/94289958-622d9180-ff0e-11ea-8467-8fbd7fbf4d11.png">
   
   ### TEST PLAN
   CI, we can't test this in dev for some reason, so I applied the same css change in our prod env and it worked
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @suddjian @graceguo-supercat 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 merged pull request #11063: fix: sql lab autocomplete width

Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #11063:
URL: https://github.com/apache/incubator-superset/pull/11063


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org