You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2025/12/12 19:16:52 UTC
[PR] fix(driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
amoeba opened a new pull request, #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797
This test covers the behavior of AdbcDatabaseGetOption with out different out buffer lengths and exposes what I think is a bug in
https://github.com/apache/arrow-adbc/blob/8ed6379bd2d8f7a7bc2b6950c9ad56ba95f71536/c/driver_manager/adbc_driver_manager.cc#L1655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797#issuecomment-3657495742
I looked at postgres and the base framework (which sqlite delegates to) and they both have the correct behavior. The Go drivers look to have the wrong logic, I'll file a follow-up PR when I confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797#issuecomment-3657570155
Update: The go driver implementation looks fine so we don't need a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797#issuecomment-3657164020
I pushed up a change to the conditional and rebased to pick up a fix for an unrelated CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797#issuecomment-3647818934
Hey @lidavidm, I saw this while debugging something else and I wasn't sure if I was understanding it right so I thought I'd put up a PR with a failing test. Does that conditional look backward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797#issuecomment-3657234515
postgresql was good, I wasn't sure about sqlite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797#issuecomment-3657250488
It looks like the Go drivers may have the same issue, I'll open a fresh PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba merged PR #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver_manager): incorrect buffer length check in AdbcDatabaseGetOption [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #3797:
URL: https://github.com/apache/arrow-adbc/pull/3797#issuecomment-3647826987
See https://github.com/apache/arrow-adbc/actions/runs/20177363761/job/57928778380?pr=3797#step:9:813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org