You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/12/05 01:19:55 UTC
Review Request 40998: Reinstated previously reverted commit around
CHECK's for ordered delivery of messages in Command Executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-3851
https://issues.apache.org/jira/browse/MESOS-3851
Repository: mesos
Description
-------
This change reinstates the previously reverted commit `b6d4b28a4c9ca717ad8be5bbc27e40c005fc51ad`
https://github.com/apache/mesos/commit/b6d4b28a4c9ca717ad8be5bbc27e40c005fc51ad#diff-3ddba917cc11631eb5ede254da408a27
Diffs
-----
src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa
Diff: https://reviews.apache.org/r/40998/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 40998: Reinstated previously reverted commit around
CHECK's for ordered delivery of messages in Command Executor.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/#review109079
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40998]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 5, 2015, 12:19 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40998/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2015, 12:19 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change reinstates the previously reverted commit `b6d4b28a4c9ca717ad8be5bbc27e40c005fc51ad`
> https://github.com/apache/mesos/commit/b6d4b28a4c9ca717ad8be5bbc27e40c005fc51ad#diff-3ddba917cc11631eb5ede254da408a27
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa
>
> Diff: https://reviews.apache.org/r/40998/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 40998: Added CHECK's for various executor states in
Command Executor to verify if messages are delivered in order.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/#review109284
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40998]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 7, 2015, 11:19 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40998/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2015, 11:19 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa
>
> Diff: https://reviews.apache.org/r/40998/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 40998: Added CHECK's for various executor states in
Command Executor to verify if messages are delivered in order.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/
-----------------------------------------------------------
(Updated Dec. 7, 2015, 11:19 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Changes based on feedback from BenM around not using an unused variable `executorInfo` but introduing an `State` enum.
Summary (updated)
-----------------
Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.
Bugs: MESOS-3851
https://issues.apache.org/jira/browse/MESOS-3851
Repository: mesos
Description (updated)
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa
Diff: https://reviews.apache.org/r/40998/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar