You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/07 03:25:47 UTC

[GitHub] [flink] Aitozi opened a new pull request, #20775: [FLINK-29088][table] Extract the common project to enhance source reuse

Aitozi opened a new pull request, #20775:
URL: https://github.com/apache/flink/pull/20775

   ## What is the purpose of the change
   
   This PR is meant to provide a way to extract the common project for the same source in a single rel tree. So that in the `SubPlanReuser` it can reuse the source as much as possible.
   
   ## Brief change log
   
   - Add a new rule `FlinkPushCommonProjectOnSourceRule` to create the common project 
   - Exclude some rules to avoid optimize the generated common project
   - Also copied two rule from calcite to avoid optimize the generated project. I think this can be removed after https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-5264
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - SubplanReuseTest#testEnableReuseTableSourceOnNewSourceProjectPushDown
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Aitozi commented on pull request #20775: [FLINK-29088][table] Extract the common project to enhance source reuse

Posted by GitBox <gi...@apache.org>.
Aitozi commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1243187012

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Aitozi commented on pull request #20775: [FLINK-29088][table] Extract the common project to enhance source reuse

Posted by GitBox <gi...@apache.org>.
Aitozi commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1242747897

   The CI failed by https://issues.apache.org/jira/browse/FLINK-29093


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-29088][table] Extract the common project to enhance source reuse [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1744498589

   @Aitozi Can you move this PR to https://github.com/apache/flink-connector-kafka ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Aitozi commented on pull request #20775: [FLINK-29088][table] Extract the common project to enhance source reuse

Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1441521005

   The failures seems related to the CI environment 
   <img width="1132" alt="image" src="https://user-images.githubusercontent.com/9486140/220881669-446cb591-6acb-44e5-9892-3afd43404209.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-29088][table] Extract the common project to enhance source reuse [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-2768303155

   This PR has been closed since it has not had any activity in 120 days. 
   If you feel like this was a mistake, or you would like to continue working on it, 
   please feel free to re-open the PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Aitozi commented on pull request #20775: [FLINK-29088][table] Extract the common project to enhance source reuse

Posted by GitBox <gi...@apache.org>.
Aitozi commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1238865375

   @twalthr @godfreyhe please help take a look when you are free 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-29088][table] Extract the common project to enhance source reuse [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-2592601713

   This PR is being marked as stale since it has not had any activity in the last 180 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   <p>
   If you are having difficulty finding a reviewer, please reach out to the 
   [community](https://flink.apache.org/what-is-flink/community/).
   <p>
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 90 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-29088][table] Extract the common project to enhance source reuse [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #20775: [FLINK-29088][table] Extract the common project to enhance source reuse
URL: https://github.com/apache/flink/pull/20775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Aitozi commented on pull request #20775: [FLINK-29088][table] Extract the common project to enhance source reuse

Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1441176867

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Aitozi commented on pull request #20775: [FLINK-29088][table] Extract the common project to enhance source reuse

Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1441277370

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-29088][table] Extract the common project to enhance source reuse [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1744499362

   @Aitozi Can you rebase this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20775: [FLINK-29088][table] Extract the common project to enhance source reuse

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20775:
URL: https://github.com/apache/flink/pull/20775#issuecomment-1238867345

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a22c18ef09fa88f415b4a71cb05682c6c43a8a42",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a22c18ef09fa88f415b4a71cb05682c6c43a8a42",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a22c18ef09fa88f415b4a71cb05682c6c43a8a42 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org