You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/31 14:05:50 UTC
[GitHub] [netbeans] sdedic opened a new pull request #3907: Relax serialized project cache checks
sdedic opened a new pull request #3907:
URL: https://github.com/apache/netbeans/pull/3907
The idea in #3375 to check the global Artifact store was good in general, BUT ...
it turned out that when the project is loading in FULL_ONLINE mode (implies no --offline switch), the NBTooling plugin [will **not** report back](https://github.com/apache/netbeans/blob/master/extide/gradle/netbeans-gradle-tooling/src/main/java/org/netbeans/modules/gradle/tooling/NbProjectInfoBuilder.java#L514) any javadocs or sources even though they may exist in the local `~/.gradle` jar cache. OK, after that the project is saved without any such artifacts, and the artifact store is updated with this imprecise info.
In some future run of the IDE, the project is fetched from the cache (without any source / javadoc), but `GradleModuleFileCache21` can find them from their binary .jar - and the cached project is deemed invalid as info in IDE's artifact store differs from the gradle's caches. So, the project **is not loaded from the cache**, but again through Gradle daemon. This time, the `FULL` level is sufficient - and that one will load even source + javadoc info - that's stored in the project cache AND in the artifact store.
TBC
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3907: Relax serialized project cache checks
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3907:
URL: https://github.com/apache/netbeans/pull/3907#issuecomment-1085107222
Yes, the description is misleading / wrong sorry; I am still working on some scenarios where serialized project is rejected despite the data in artifact store are still valid. For now just ignore the description - will update :) before going from draft stage.
Or do you mean the whole concept of the artifact store is superseded by the GradleModuleFileCache21 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3907: Relax serialized project cache checks
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3907:
URL: https://github.com/apache/netbeans/pull/3907#issuecomment-1085087307
Let me add some history on this.
So at the initial phase of the Gradle plugin, all JavaDoc and Source information was retrieved directly by the tooling plugin. These are treated as miscellaneous information. They are not serialized along the other project information,rather than kept a globally serialized artifact store updated.
With the introduction of the GradleModuleFileCache21 the globally serialized artifact store could be redundant, as the javadoc and source information could be retrieved directly from the cache.
So probably it would be wise to revisit the handling of this information and remove some code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3907: Relax serialized project cache checks
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3907:
URL: https://github.com/apache/netbeans/pull/3907#issuecomment-1085156558
> Or do you mean the whole concept of the artifact store is superseded by the GradleModuleFileCache21 ?
Yes. I think that's possible. At the moment I can't name any use-case where GradleModuleFileCache21 with additional heuristics for Maven and File dependencies would not be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3907: Relax serialized project cache checks
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3907:
URL: https://github.com/apache/netbeans/pull/3907#issuecomment-1085946470
Consolidated; description updated.
> So probably it would be wise to revisit the handling of this information and remove some code.
It could be much better, but we are about to release vscode in a few weeks, and I'd rather not to disrupt things. So far the changes made here are pretty local, not affecting other things than the loading process - and greatly improve project loading time.
Let's do the cleanup in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists