You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/01/18 11:38:52 UTC
[GitHub] [activemq-artemis] andytaylor opened a new pull request #3410: More console fixes
andytaylor opened a new pull request #3410:
URL: https://github.com/apache/activemq-artemis/pull/3410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on a change in pull request #3410: More console fixes
Posted by GitBox <gi...@apache.org>.
andytaylor commented on a change in pull request #3410:
URL: https://github.com/apache/activemq-artemis/pull/3410#discussion_r560222545
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -3430,21 +3430,21 @@ public void addAddressSettings(final String address,
addressSettings.setAutoDeleteQueues(autoDeleteQueues);
addressSettings.setAutoCreateAddresses(autoCreateAddresses);
addressSettings.setAutoDeleteAddresses(autoDeleteAddresses);
- addressSettings.setConfigDeleteQueues(configDeleteQueues == null ? AddressSettings.DEFAULT_CONFIG_DELETE_QUEUES : DeletionPolicy.valueOf(configDeleteQueues.toUpperCase()));
- addressSettings.setConfigDeleteAddresses(configDeleteAddresses == null ? AddressSettings.DEFAULT_CONFIG_DELETE_ADDRESSES : DeletionPolicy.valueOf(configDeleteAddresses.toUpperCase()));
+ addressSettings.setConfigDeleteQueues(configDeleteQueues == null || configDeleteQueues.length() == 0 ? AddressSettings.DEFAULT_CONFIG_DELETE_QUEUES : DeletionPolicy.valueOf(configDeleteQueues.toUpperCase()));
+ addressSettings.setConfigDeleteAddresses(configDeleteAddresses == null || configDeleteAddresses.length() == 0 ? AddressSettings.DEFAULT_CONFIG_DELETE_ADDRESSES : DeletionPolicy.valueOf(configDeleteAddresses.toUpperCase()));
addressSettings.setMaxSizeBytesRejectThreshold(maxSizeBytesRejectThreshold);
- addressSettings.setDefaultLastValueKey(defaultLastValueKey == null ? ActiveMQDefaultConfiguration.getDefaultLastValueKey() : new SimpleString(defaultLastValueKey));
+ addressSettings.setDefaultLastValueKey(defaultLastValueKey == null || defaultLastValueKey.length() == 0 ? ActiveMQDefaultConfiguration.getDefaultLastValueKey() : new SimpleString(defaultLastValueKey));
Review comment:
yip, updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3410: More console fixes
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3410:
URL: https://github.com/apache/activemq-artemis/pull/3410#issuecomment-762487564
nit-pick...
NO-JIRA Updating the console docs
And the commit message.. if you could say the substantial part in the first line? It makes it a lot easier when we are looking on the logs...
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3410: More console fixes
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on a change in pull request #3410:
URL: https://github.com/apache/activemq-artemis/pull/3410#discussion_r560134075
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -3430,21 +3430,21 @@ public void addAddressSettings(final String address,
addressSettings.setAutoDeleteQueues(autoDeleteQueues);
addressSettings.setAutoCreateAddresses(autoCreateAddresses);
addressSettings.setAutoDeleteAddresses(autoDeleteAddresses);
- addressSettings.setConfigDeleteQueues(configDeleteQueues == null ? AddressSettings.DEFAULT_CONFIG_DELETE_QUEUES : DeletionPolicy.valueOf(configDeleteQueues.toUpperCase()));
- addressSettings.setConfigDeleteAddresses(configDeleteAddresses == null ? AddressSettings.DEFAULT_CONFIG_DELETE_ADDRESSES : DeletionPolicy.valueOf(configDeleteAddresses.toUpperCase()));
+ addressSettings.setConfigDeleteQueues(configDeleteQueues == null || configDeleteQueues.length() == 0 ? AddressSettings.DEFAULT_CONFIG_DELETE_QUEUES : DeletionPolicy.valueOf(configDeleteQueues.toUpperCase()));
+ addressSettings.setConfigDeleteAddresses(configDeleteAddresses == null || configDeleteAddresses.length() == 0 ? AddressSettings.DEFAULT_CONFIG_DELETE_ADDRESSES : DeletionPolicy.valueOf(configDeleteAddresses.toUpperCase()));
addressSettings.setMaxSizeBytesRejectThreshold(maxSizeBytesRejectThreshold);
- addressSettings.setDefaultLastValueKey(defaultLastValueKey == null ? ActiveMQDefaultConfiguration.getDefaultLastValueKey() : new SimpleString(defaultLastValueKey));
+ addressSettings.setDefaultLastValueKey(defaultLastValueKey == null || defaultLastValueKey.length() == 0 ? ActiveMQDefaultConfiguration.getDefaultLastValueKey() : new SimpleString(defaultLastValueKey));
Review comment:
why not use isEmpty()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit merged pull request #3410: More console fixes
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3410:
URL: https://github.com/apache/activemq-artemis/pull/3410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] mpoutlook commented on a change in pull request #3410: More console fixes
Posted by GitBox <gi...@apache.org>.
mpoutlook commented on a change in pull request #3410:
URL: https://github.com/apache/activemq-artemis/pull/3410#discussion_r560133656
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -3430,21 +3430,21 @@ public void addAddressSettings(final String address,
addressSettings.setAutoDeleteQueues(autoDeleteQueues);
addressSettings.setAutoCreateAddresses(autoCreateAddresses);
addressSettings.setAutoDeleteAddresses(autoDeleteAddresses);
- addressSettings.setConfigDeleteQueues(configDeleteQueues == null ? AddressSettings.DEFAULT_CONFIG_DELETE_QUEUES : DeletionPolicy.valueOf(configDeleteQueues.toUpperCase()));
- addressSettings.setConfigDeleteAddresses(configDeleteAddresses == null ? AddressSettings.DEFAULT_CONFIG_DELETE_ADDRESSES : DeletionPolicy.valueOf(configDeleteAddresses.toUpperCase()));
+ addressSettings.setConfigDeleteQueues(configDeleteQueues == null || configDeleteQueues.length() == 0 ? AddressSettings.DEFAULT_CONFIG_DELETE_QUEUES : DeletionPolicy.valueOf(configDeleteQueues.toUpperCase()));
Review comment:
why not use isEmpty()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3410: More console fixes
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3410:
URL: https://github.com/apache/activemq-artemis/pull/3410#issuecomment-762710059
@clebertsuconic nit pick fixed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org